Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Port to glib 0.18 #3029

Merged
merged 2 commits into from
Sep 6, 2023
Merged

rust: Port to glib 0.18 #3029

merged 2 commits into from
Sep 6, 2023

Conversation

cgwalters
Copy link
Member

rust: Port to glib 0.18

  • Also rolls up a few other changes in the C API
  • Drop &mut from OstreeKernelArgs; it now confuses type inference.
    More generally while using &mut here was well intentioned, it
    goes against the glib standard of mapping everything to & and
    accepting interior mutability.

rust: Bump semver to 0.19

  • New glib 0.18 dependency
  • Drop cap-std APIs and features
  • Other minor changes

@cgwalters cgwalters added area/rust-bindings Relates to the Rust bindings for the C library reward/medium Fixing this will be notably useful labels Sep 1, 2023
- Also rolls up a few other changes in the C API
- Drop `&mut` from `OstreeKernelArgs`; it now confuses type inference.
  More generally while using `&mut` here was well intentioned, it
  goes against the glib standard of mapping everything to `&` and
  accepting interior mutability.
- New glib 0.18 dependency
- Drop cap-std APIs and features
- Other minor changes
@cgwalters
Copy link
Member Author

This one should be good to go

Copy link
Collaborator

@ericcurtin ericcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm at a beginner level of Rust knowledge.

@cgwalters cgwalters merged commit b0e3281 into ostreedev:main Sep 6, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rust-bindings Relates to the Rust bindings for the C library reward/medium Fixing this will be notably useful
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants