Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysroot: Stabilize deployment finalization, add API #3090

Merged
merged 3 commits into from
Nov 27, 2023
Merged

sysroot: Stabilize deployment finalization, add API #3090

merged 3 commits into from
Nov 27, 2023

Commits on Nov 27, 2023

  1. tests: Turn off gpg verification for dev builds 

    Right now `ostree admin status` errors out in this case, but
`rpm-ostree status` doesn't.  The former behavior is probably
more of a bug, work around it for now.
    @cgwalters
    cgwalters committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b6f435f View commit details
    Browse the repository at this point in the history

  2. status: Add error prefix for gpg verification 

    It's helpful to see which deployment has an error.
    @cgwalters
    cgwalters committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    1ca4f02 View commit details
    Browse the repository at this point in the history

  3. sysroot: Stabilize deployment finalization, add API and CLI 

    It's about time we do this; deployment finalization locking
is a useful feature.  An absolutely key thing here is that
we've slowly been moving towards the deployments as the primary
"source of truth".

Specifically in bootc for example, we will GC container images
not referenced by a deployment.

This is then neecessary to support a "pull but don't apply automatically" model.

This stabilizes the existing `ostree admin deploy --lock-finalization`
CLI, and adds a new `ostree admin unlock-finalization`.

We still check the old lock file path, but there's a new boolean
value as part of the staged deployment data which is intended
to be the source of truth in the future.  At some point then we
can drop the rpm-ostree lockfile handling.

Closes: ostreedev#3025
    @cgwalters
    cgwalters committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    28cc761 View commit details
    Browse the repository at this point in the history