-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to external composefs #3108
Conversation
fde20ee
to
d61ebc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane offhand.
For CI, short-term easiest is to just run ci/installdeps.sh
in the build container until the buildroot image catches up.
I've belatedly realized that not having composefs shipped in current c9s is going to make this more logistically complicated. I think that will likely happen, but hard to say when. |
Yeah, for practical reason, maybe hold off on this a bit. |
9a8ddce
to
abe971b
Compare
OK composefs is in c9s, rebased 🏄 |
abe971b
to
67e0cad
Compare
Yeah, various CI failures because our build/runtime deps come from packaging and that breaks when dropping in new binaries. I did https://src.fedoraproject.org/rpms/ostree/c/b64d73f3718115cb9d6926275e21f5b16c3f14f9?branch=rawhide as one fix. |
67e0cad
to
7c71fcd
Compare
9685989
to
3e2d44e
Compare
Ah, this needs coreos/fedora-coreos-config#2900 at least |
Previously this was masked by us shipping composefs vendored.
Right now there's skew where we don't have composefs-devel in the buildroot. In general this optimization isn't worth it.
Since there's now a stable shared library, let's use it.
3e2d44e
to
eb54a44
Compare
Since there's now a stable shared library, let's use it.