Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipl: A few fixes #3119

Merged
merged 4 commits into from
Jan 2, 2024
Merged

zipl: A few fixes #3119

merged 4 commits into from
Jan 2, 2024

Conversation

cgwalters
Copy link
Member

zipl: Use O_CLOEXEC

On general principle.


zipl: Fix error handling for read

The return value is not errno.


zipl: NUL terminate buffer we're searching

Found by a static analyzer.


zipl: Convert to a data input stream

This high level reader API avoids all the bugs that were
found in prevoius patches.


On general principle.
The return value is not errno.
Found by a static analyzer.
This high level reader API avoids all the bugs that were
found in previous patches.
@cgwalters
Copy link
Member Author

@nikita-dubrovskii mind reviewing?

@cgwalters
Copy link
Member Author

This one should be good to merge I think.

Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero jmarrero merged commit ba12a16 into ostreedev:main Jan 2, 2024
24 checks passed
@cgwalters cgwalters mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants