status: Fix build without GPGME #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes broken build from: |
cgwalters
reviewed
Jan 5, 2024
|
BTW procedural point; we try to use "topic prefixes" in this repo and also the subject should be in the "imperative mood". So the commit message could look more like (but also rewording with the new suggestion):
|
ericcurtin
changed the title
|
Repushed with changes. |
If OSTREE_DISABLE_GPGME is not built in set remote to NULL. The ostree_repo_signature_verify_commit_data path is irrelevant in the no gpg case anyway. Having this set as NULL ensures an error gets thrown early. Signed-off-by: Eric Curtin <ecurtin@redhat.com>
cgwalters
approved these changes
Jan 5, 2024
ericcurtin
force-pushed
the
query-boot
branch
2 times, most recently
from
916e4cd
to
37971a9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If OSTREE_DISABLE_GPGME is not built in set remote to NULL.
The ostree_repo_signature_verify_commit_data path is irrelevant in the
no gpg case anyway. Having this set as NULL ensures an error gets
thrown early.