Fix booted deploy detection with transient /etc #3163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When /etc is transient, and composefs is root, there is currently no bind-mount of the deploy directory so the checks for finding if a deploy is booted are failing. We fix this by bind-mounting the deploy dir as /run/ostree/deploy and use that to look for the booted deploy directory.
github-actions
bot
added
the
area/prepare-root
Merged
|
I'm OK with this probably as is, but WDYT about just injecting the device/inode pair into the |
|
That would work to, lemme try it out and see how it ends up- |
|
I took a quick stab at this in #3164 - testing now |
|
Given the weird error in the CI here i prefer the #3164 approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When /etc is transient, and composefs is root, there is currently no bind-mount of the deploy directory so the checks for finding if a deploy is booted are failing.
We fix this by bind-mounting the deploy dir as /run/ostree/deploy and use that to look for the booted deploy directory.
This fixes: #3161