Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-admin-deploy-var: Don't rely on OSTREE_FEATURES #3184

Merged
merged 3 commits into from
Feb 21, 2024
Merged

test-admin-deploy-var: Don't rely on OSTREE_FEATURES #3184

merged 3 commits into from
Feb 21, 2024

Commits on Feb 19, 2024

  1. tests: Generalize has_gpgme, has_sign_ed25519 into has_ostree_feature 

    Signed-off-by: Simon McVittie <smcv@collabora.com>
    @smcv
    smcv committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    a84e56d View commit details
    Browse the repository at this point in the history

  2. tests: Use skip_without_ostree_feature to detect libarchive, composefs 

    This avoids false negatives from `ostree --version | grep -q ...`
exiting with failure under `set -o pipefail` because `grep -q` can exit
as soon as it sees the desired string, leaving `ostree --version` to be
terminated by `SIGPIPE` next time it writes to stdout.

Signed-off-by: Simon McVittie <smcv@collabora.com>
    @smcv
    smcv committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    37466ec View commit details
    Browse the repository at this point in the history

  3. test-admin-deploy-var: Don't rely on OSTREE_FEATURES 

    This is set during build-time testing, but unset during "as-installed"
tests.

Resolves: ostreedev#3183
Signed-off-by: Simon McVittie <smcv@debian.org>
    @smcv
    smcv committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    035b2c1 View commit details
    Browse the repository at this point in the history