Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libostree: Allow compression level to be set for archive-z2 stream #721

Closed
wants to merge 1 commit into from

Conversation

pwithnall
Copy link
Member

Add a ostree_raw_file_to_archive_z2_stream_with_options() variant of
ostree_raw_file_to_archive_z2_stream(), to allow a compression-level
option to be passed in and passed through to zlib.

This is useful when building archive-z2 files on the fly for
transmission over a non-bandwidth-limited channel, such as a local
network. In this case, CPU time is more valuable than bandwidth, so we
want a low compression level.

Signed-off-by: Philip Withnall withnall@endlessm.com

Add a ostree_raw_file_to_archive_z2_stream_with_options() variant of
ostree_raw_file_to_archive_z2_stream(), to allow a compression-level
option to be passed in and passed through to zlib.

This is useful when building archive-z2 files on the fly for
transmission over a non-bandwidth-limited channel, such as a local
network. In this case, CPU time is more valuable than bandwidth, so we
want a low compression level.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
@rh-atomic-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@cgwalters
Copy link
Member

LGTM, I'll just note this is related to #671

@rh-atomic-bot r+ 5cae9a5

@cgwalters
Copy link
Member

bot, add author to whitelist

@pwithnall
Copy link
Member Author

LGTM, I'll just note this is related to #671

Yeah, I saw that. Looking at it again, perhaps it would make sense for me to name my new option zlib-level rather than compression-level, for consistency with #671?

@cgwalters
Copy link
Member

Eh, not worth a respin IMO (this patch is already queued for commit).

@rh-atomic-bot
Copy link

⌛ Testing commit 5cae9a5 with merge 574c3ea...

@rh-atomic-bot
Copy link

☀️ Test successful - status-atomicjenkins
Approved by: cgwalters
Pushing 574c3ea to master...

@vtolstov
Copy link

vtolstov commented Mar 6, 2017 via email

@pwithnall
Copy link
Member Author

So compression-level or zlib-level ?

It was committed with compression-level. I’m happy with it either way.

@pwithnall pwithnall deleted the compression branch March 7, 2017 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants