-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libostree: Allow compression level to be set for archive-z2 stream #721
Conversation
Add a ostree_raw_file_to_archive_z2_stream_with_options() variant of ostree_raw_file_to_archive_z2_stream(), to allow a compression-level option to be passed in and passed through to zlib. This is useful when building archive-z2 files on the fly for transmission over a non-bandwidth-limited channel, such as a local network. In this case, CPU time is more valuable than bandwidth, so we want a low compression level. Signed-off-by: Philip Withnall <withnall@endlessm.com>
Can one of the admins verify this patch?
|
LGTM, I'll just note this is related to #671 |
bot, add author to whitelist |
Eh, not worth a respin IMO (this patch is already queued for commit). |
☀️ Test successful - status-atomicjenkins |
So compression-level or zlib-level ?
2017-03-06 21:33 GMT+03:00 Atomic Bot <notifications@github.com>:
… ☀️ Test successful - status-atomicjenkins
<https://s3.amazonaws.com/aos-ci/ghprb/ostreedev/ostree/574c3ea6f935c392da99a721907a98086eeaad44.1488825237576891904/index.html>
Approved by: cgwalters
Pushing 574c3ea
<574c3ea>
to master...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#721 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAdYG1dQXeezw6UTw9zVjxeT9JB6ZMXsks5rjFGMgaJpZM4MUemO>
.
--
Vasiliy Tolstov,
e-mail: v.tolstov@selfip.ru
|
It was committed with |
Add a ostree_raw_file_to_archive_z2_stream_with_options() variant of
ostree_raw_file_to_archive_z2_stream(), to allow a compression-level
option to be passed in and passed through to zlib.
This is useful when building archive-z2 files on the fly for
transmission over a non-bandwidth-limited channel, such as a local
network. In this case, CPU time is more valuable than bandwidth, so we
want a low compression level.
Signed-off-by: Philip Withnall withnall@endlessm.com