Add user parameter to projects. #290
Conversation
|
On a side note, I think that we should refactor the times tests to look more like this. One list of all times, then use filter() and map() to get the expected results for a given test, instead of redefining the whole list every time. It'll make it easier to maintain and reduce unnecessary redundancy. |
|
These tests look good. To address the side note I would not refactor the time tests unless you find yourself working on the time tests anyway. |
|
Agreed. |
| @@ -198,6 +198,47 @@ module.exports = function(expect, request, baseUrl) { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('GET /projects?user=:username', function() { | |||
| it('returns all times for a user', function(done) { | |||
There was a problem hiding this comment.
you mean "returns all projects for a user"?
|
Another note for a tests refactor - we should really replace user/project/activity names with generic names like user1, user2, project1, project2, (or valid_user_1, invalid_project, etc) rather than have gwm and tschuy all over our test data. A recursive /tschuy/user_1/ should take care of that pretty easily. |
|
LGTM +1 |
|
+1 |
fixes issue #289
Changes in this PR.
Testing this PR.
npm test./projects?user=tschuy.Expected Output.
@osuosl/devs