fix: crash in scope analysis when using espree

.changeset/chilly-numbers-smell.md

@@ -0,0 +1,5 @@
+---
+"astro-eslint-parser": patch
+---
+
+fix: crash in scope analysis when using espree

.github/workflows/NodeCI.yml

@@ -25,34 +25,15 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [20.x, 22.x]
+        node-version: [18.x, 20.x, 22.x]
     steps:
     - uses: actions/checkout@v4
     - name: Use Node.js ${{ matrix.node-version }}
       uses: actions/setup-node@v4
       with:
         node-version: ${{ matrix.node-version }}
     - name: Install Packages
-      run: npm install --legacy-peer-deps
-    - name: Test
-      run: npm test
-  test-for-old-node:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        node-version: [18.x]
-    steps:
-    - uses: actions/checkout@v4
-    - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v4
-      with:
-        node-version: ${{ matrix.node-version }}
-    - name: Install old versions
-      run: |+
-        npm i -D @typescript-eslint/parser@5 @typescript-eslint/eslint-plugin@5 --legacy-peer-deps
-        npx rimraf node_modules
-    - name: Install Packages
-      run: npm install --legacy-peer-deps
+      run: npm install -f
     - name: Test
       run: npm test
   test-for-eslint-v7:
@@ -68,10 +49,10 @@ jobs:
         node-version: ${{ matrix.node-version }}
     - name: Install eslint v7
       run: |+
-        npm i -D eslint@7 @typescript-eslint/parser@5 @typescript-eslint/eslint-plugin@5 --legacy-peer-deps
+        npm i -D eslint@7 @typescript-eslint/parser@5 @typescript-eslint/eslint-plugin@5 -f
         npx rimraf node_modules
     - name: Install Packages
-      run: npm install --legacy-peer-deps
+      run: npm install -f
     - name: Test
       run: npm test
   test-and-coverage:
@@ -84,6 +65,6 @@ jobs:
     - name: Test
       run: npm run cover
     - name: Coveralls GitHub Action
-      uses: coverallsapp/github-action@3dfc5567390f6fa9267c0ee9c251e4c8c3f18949 # v2.2.3
+      uses: coverallsapp/github-action@v2.2.3
       with:
         github-token: ${{ secrets.GITHUB_TOKEN }}

package.json

@@ -55,6 +55,7 @@
     "astrojs-compiler-sync": "^1.0.0",
     "debug": "^4.3.4",
     "entities": "^4.5.0",
+    "eslint-scope": "^8.0.1",
     "eslint-visitor-keys": "^4.0.0",
     "espree": "^10.0.0",
     "globby": "^11.1.0",

src/parser/script.ts

@@ -1,10 +1,17 @@
 import type { Context } from "../context";
 import { debug } from "../debug";
-import type { ParserOptionsContext } from "../context/parser-options";
+import type {
+  ParserOptions,
+  ParserOptionsContext,
+} from "../context/parser-options";
 import type { ESLintExtendedProgram } from "../types";
 import { tsPatch } from "./ts-patch";
 import { isEnhancedParserObject } from "../context/resolve-parser/parser-object";
-import { analyze } from "@typescript-eslint/scope-manager";
+import type { ScopeManager } from "@typescript-eslint/scope-manager";
+import { analyze as analyzeForTypeScript } from "@typescript-eslint/scope-manager";
+import { analyze as analyzeForEcmaScript } from "eslint-scope";
+import { KEYS } from "../visitor-keys";
+import { getKeys } from "../traverse";
 /**
  * Parse for script
  */
@@ -17,17 +24,45 @@ export function parseScript(
 
   const parserOptions = parserOptionsCtx.parserOptions;
   if (!result.scopeManager && parserOptions.eslintScopeManager) {
-    result.scopeManager = analyze(result.ast, {
-      ecmaVersion: 1e8,
+    result.scopeManager = analyzeScope(result, parserOptions);
+  }
+
+  return result;
+}
+
+/**
+ * Analyze scope
+ */
+function analyzeScope(
+  result: ESLintExtendedProgram,
+  parserOptions: ParserOptions,
+): ScopeManager {
+  try {
+    return analyzeForTypeScript(result.ast, {
       globalReturn: parserOptions.ecmaFeatures?.globalReturn,
       jsxPragma: parserOptions.jsxPragma,
       jsxFragmentName: parserOptions.jsxFragmentName,
       lib: parserOptions.lib,
       sourceType: parserOptions.sourceType,
     });
+  } catch {
+    // ignore
   }
+  const ecmaFeatures = parserOptions.ecmaFeatures || {};
 
-  return result;
+  return analyzeForEcmaScript(result.ast, {
+    ignoreEval: true,
+    nodejsScope: ecmaFeatures.globalReturn,
+    impliedStrict: ecmaFeatures.impliedStrict as never,
+    ecmaVersion: 1e8,
+    sourceType:
+      parserOptions.sourceType === "commonjs"
+        ? "script"
+        : parserOptions.sourceType || "script",
+    // @ts-expect-error -- Type bug?
+    childVisitorKeys: result.visitorKeys || KEYS,
+    fallback: getKeys,
+  }) as ScopeManager;
 }
 
 /**

tests/fixtures/parser/ast/js-jsx01-requirements.json

@@ -0,0 +1,5 @@
+{
+    "scope": {
+        "@typescript-eslint/parser" : ">=7"
+    }
+}

tests/fixtures/parser/ast/js-jsx01-scope-output.json

@@ -1 +1,180 @@
-null
+{
+  "type": "global",
+  "variables": [],
+  "references": [],
+  "childScopes": [
+    {
+      "type": "module",
+      "variables": [
+        {
+          "name": "MyComponent",
+          "identifiers": [
+            {
+              "type": "Identifier",
+              "name": "MyComponent",
+              "range": [
+                11,
+                22
+              ],
+              "loc": {
+                "start": {
+                  "line": 2,
+                  "column": 7
+                },
+                "end": {
+                  "line": 2,
+                  "column": 18
+                }
+              }
+            }
+          ],
+          "defs": [
+            {
+              "type": "ImportBinding",
+              "name": {
+                "type": "Identifier",
+                "name": "MyComponent",
+                "range": [
+                  11,
+                  22
+                ],
+                "loc": {
+                  "start": {
+                    "line": 2,
+                    "column": 7
+                  },
+                  "end": {
+                    "line": 2,
+                    "column": 18
+                  }
+                }
+              },
+              "node": {
+                "type": "ImportDefaultSpecifier",
+                "local": {
+                  "type": "Identifier",
+                  "name": "MyComponent",
+                  "range": [
+                    11,
+                    22
+                  ],
+                  "loc": {
+                    "start": {
+                      "line": 2,
+                      "column": 7
+                    },
+                    "end": {
+                      "line": 2,
+                      "column": 18
+                    }
+                  }
+                },
+                "range": [
+                  11,
+                  22
+                ],
+                "loc": {
+                  "start": {
+                    "line": 2,
+                    "column": 7
+                  },
+                  "end": {
+                    "line": 2,
+                    "column": 18
+                  }
+                }
+              }
+            }
+          ],
+          "references": [
+            {
+              "identifier": {
+                "type": "JSXIdentifier",
+                "name": "MyComponent",
+                "range": [
+                  57,
+                  68
+                ],
+                "loc": {
+                  "start": {
+                    "line": 5,
+                    "column": 1
+                  },
+                  "end": {
+                    "line": 5,
+                    "column": 12
+                  }
+                }
+              },
+              "from": "module",
+              "init": null,
+              "resolved": {
+                "type": "Identifier",
+                "name": "MyComponent",
+                "range": [
+                  11,
+                  22
+                ],
+                "loc": {
+                  "start": {
+                    "line": 2,
+                    "column": 7
+                  },
+                  "end": {
+                    "line": 2,
+                    "column": 18
+                  }
+                }
+              }
+            }
+          ]
+        }
+      ],
+      "references": [
+        {
+          "identifier": {
+            "type": "JSXIdentifier",
+            "name": "MyComponent",
+            "range": [
+              57,
+              68
+            ],
+            "loc": {
+              "start": {
+                "line": 5,
+                "column": 1
+              },
+              "end": {
+                "line": 5,
+                "column": 12
+              }
+            }
+          },
+          "from": "module",
+          "init": null,
+          "resolved": {
+            "type": "Identifier",
+            "name": "MyComponent",
+            "range": [
+              11,
+              22
+            ],
+            "loc": {
+              "start": {
+                "line": 2,
+                "column": 7
+              },
+              "end": {
+                "line": 2,
+                "column": 18
+              }
+            }
+          }
+        }
+      ],
+      "childScopes": [],
+      "through": []
+    }
+  ],
+  "through": []
+}

tests/fixtures/parser/ast/js-test01-input.astro

@@ -0,0 +1,19 @@
+---
+const sidebarSections = [{ text: "foo" }]
+---
+
+<nav aria-labelledby="grid-left">
+  <ul class="nav-groups">
+    {sidebarSections.map((section) => (
+      <li>
+        <div class="nav-group">{section.text}</div>
+      </li>
+    ))}
+  </ul>
+</nav>
+
+<style>
+  .nav-groups > li + li {
+    margin-top: 2rem;
+  }
+</style>