Include Java module descriptor #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sormuras
force-pushed
the
include-precompiled-module-descriptor
branch
from
41bb248
to
2d5882f
Compare
eolivelli
approved these changes
Jun 3, 2019
sormuras
force-pushed
the
include-precompiled-module-descriptor
branch
from
2d5882f
to
a75b1bc
Compare
sormuras
changed the title
sormuras
force-pushed
the
include-precompiled-module-descriptor
branch
from
a75b1bc
to
8a860d3
Compare
marcphilipp
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Supersedes and closes #51 by including Java module descriptor at the root of the generated JAR file.
This PR upgrades the JDK required to build the project to 11.
I hereby agree to the terms of the Open Test Alliance Contributor License Agreement.