Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package should be published not minimized #196

Closed
bodinsamuel opened this issue Mar 23, 2023 · 3 comments
Closed

Package should be published not minimized #196

bodinsamuel opened this issue Mar 23, 2023 · 3 comments
Labels

Comments

@bodinsamuel
Copy link
Contributor

Hey,

I have started using this package, it works great thank you :)
I just encountered two issues:

  • The mapping doesn't work in the browser, not sure why but might be related to the second issue
  • The package is compiled which makes it hardly debuggable, and increase our own bundle because it will have duplicated compilation stuff (like iterators, babel, etc...)

If you want to published it compiled and minimized you can have an other folder with it, but having the source in .js + d.ts would be more than awesome, thanks ☺️

@otakustay
Copy link
Owner

otakustay commented Mar 24, 2023

Yes exactly, I prepare to do this in next major, changing publish format is a breaking change currently.

For your case, now I'm going to publish both minified and compiled code in a single package, you can import {Diff} from 'react-diff-view/esm'

@bodinsamuel
Copy link
Contributor Author

Amazing news, thanks a lot ☺️

@stale
Copy link

stale bot commented May 1, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 1, 2023
@stale stale bot closed this as completed May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants