Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8 response decoder called if no content type is present #9

Merged

Conversation

othercodes
Copy link
Owner

Now the decoders check the presence of the content-type header and the body.

@codecov
Copy link

codecov bot commented Oct 9, 2017

Codecov Report

Merging #9 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #9      +/-   ##
============================================
- Coverage     63.56%   63.48%   -0.09%     
- Complexity      143      147       +4     
============================================
  Files            15       15              
  Lines           409      419      +10     
============================================
+ Hits            260      266       +6     
- Misses          149      153       +4
Impacted Files Coverage Δ Complexity Δ
src/Payloads/Headers.php 84% <100%> (-9.19%) 18 <2> (+2)
src/Payloads/Response.php 82.35% <100%> (ø) 11 <0> (ø) ⬇️
src/Modules/Decoders/BaseDecoder.php 76.92% <100%> (+10.25%) 6 <0> (+2) ⬆️
src/Modules/BaseModule.php 75% <0%> (+6.25%) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcdb3bb...7a37662. Read the comment docs.

@othercodes othercodes merged commit f513fbe into master Oct 10, 2017
@othercodes othercodes deleted the 8-response-decoder-called-if-no-content-type-is-present branch October 13, 2017 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant