Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum level to send private #3689

Merged
merged 11 commits into from
Oct 9, 2021
Merged

Add minimum level to send private #3689

merged 11 commits into from
Oct 9, 2021

Conversation

ramon-bernardo
Copy link
Contributor

@ramon-bernardo ramon-bernardo commented Sep 25, 2021

Pull Request Prelude

Changes Proposed

  • add minimum level to send private
  • players with group access or ignoresendprivatecheck flag ignore this check

@EPuncker EPuncker added enhancement Increase or improvement in quality, value, or extent priority: low Issues with this label won’t have the immediate focus labels Sep 25, 2021
@EPuncker
Copy link
Contributor

EPuncker commented Sep 25, 2021

this is really great, specially to prevent those users who use tools to gather all player names online and private message them to advertise something, lets see what others will say.

@soul4soul
Copy link
Contributor

Lately we have had a few commits removing hard coded options. Instead of hard coding the GM check and adding yet another config option can this be added as a group flag?

@ramon-bernardo
Copy link
Contributor Author

ramon-bernardo commented Sep 25, 2021

this is really great, specially to prevent those users who use tools to gather all player names online and private message them to advertise something, lets see what others will say.

Ok

Lately we have had a few commits removing hard coded options. Instead of hard coding the GM check and adding yet another config option can this be added as a group flag?

Good, added new flag

  • const.h may conflict with PlayerFlag_IgnoreYellCheck = static_cast<uint64_t>(1) << 38

EPuncker
EPuncker previously approved these changes Sep 25, 2021
Copy link
Member

@ranisalt ranisalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Casing issue

ranisalt
ranisalt previously approved these changes Sep 26, 2021
Copy link
Member

@ranisalt ranisalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github got me all confused here lol

EPuncker
EPuncker previously approved these changes Sep 26, 2021
@ramon-bernardo ramon-bernardo dismissed stale reviews from EPuncker and ranisalt via 8b33385 October 3, 2021 10:48
Copy link
Member

@DSpeichert DSpeichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this wording copied from RL or custom?

src/game.cpp Outdated Show resolved Hide resolved
src/game.cpp Outdated Show resolved Hide resolved
ramon-bernardo and others added 2 commits October 3, 2021 16:35
Co-authored-by: Daniel Speichert <DSpeichert@users.noreply.github.com>
Co-authored-by: Daniel Speichert <DSpeichert@users.noreply.github.com>
@ramon-bernardo
Copy link
Contributor Author

I noticed now, premiumToSendPrivate is confused. Any suggestion?

  • privateMessageAlwaysAllowPremium
  • sendPrivateAlwaysAllowPremium
  • sendPrivateMessageAlwaysAllowPremium

and minimumLevelToSendPrivate to minimumLevelToSendPrivateMessage

data/XML/groups.xml Outdated Show resolved Hide resolved
data/XML/groups.xml Outdated Show resolved Hide resolved
data/XML/groups.xml Outdated Show resolved Hide resolved
@DSpeichert DSpeichert merged commit 4ee3b76 into otland:master Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Increase or improvement in quality, value, or extent priority: low Issues with this label won’t have the immediate focus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants