Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for length player name #3760

Merged
merged 4 commits into from
Nov 29, 2021
Merged

Add config for length player name #3760

merged 4 commits into from
Nov 29, 2021

Conversation

ramon-bernardo
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • Add config for lenght player name
  • Now we can easily change to 25 and have 12.x support

src/game.cpp Outdated Show resolved Hide resolved
src/game.cpp Outdated Show resolved Hide resolved
src/game.cpp Outdated Show resolved Hide resolved
src/game.h Outdated Show resolved Hide resolved
@EPuncker EPuncker changed the title Add config for lenght player name Add config for length player name Nov 29, 2021
@EPuncker EPuncker merged commit 4183bad into otland:master Nov 29, 2021
@EPuncker EPuncker deleted the player-name-lenght branch November 29, 2021 05:00
@Zbizu
Copy link
Contributor

Zbizu commented Nov 29, 2021

there doesn't seem to be any real limit to names length from client side
Edit: 8192 chars probably, roughly enough to fill half of the screen. Also: XML supports <br /> tag in monster name, but ignores other tags.
obraz

I wasn't able to log in as a character with more than 70 chars in name though.

EPuncker pushed a commit to EPuncker/forgottenserver that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants