Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small update to channel requirements #3859

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Small update to channel requirements #3859

merged 2 commits into from
Jan 24, 2022

Conversation

EPuncker
Copy link
Contributor

@EPuncker EPuncker commented Dec 17, 2021 •
edited
Loading

Pull Request Prelude

Changes Proposed

  • added onJoin message to both advertising channels
  • removed level check from rook-advertising
  • changed level from 1 to 20 and added premium requirement to bypass it
  • updated message accordingly

yes these changes are based on cipbia but I added them because they make sense, not to mimic

DSpeichert
DSpeichert requested changes Dec 21, 2021
View reviewed changes
Copy link
Member

@DSpeichert DSpeichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? x3

data/chatchannels/scripts/advertising.lua Outdated Show resolved Hide resolved
@omarcopires
Copy link
Contributor

This is the actual behavior of channels, everything looks right, there is no reason not to add it.

@DSpeichert DSpeichert merged commit f7db9bc into otland:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omarcopires omarcopires omarcopires approved these changes

@DSpeichert DSpeichert DSpeichert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EPuncker @omarcopires @DSpeichert