Fix checksum mode for new Qt client ids #4088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Apr 22, 2022
DSpeichert
approved these changes
Apr 22, 2022
Codinablack
pushed a commit
to Codinablack/forgottenserver
that referenced
this pull request
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
It looks like (some of) the Qt clients got new client IDs. When connecting with client v12.86.11871 on Linux I get 7 instead of the expected 4. This was crashing the client because the checksum mode would be incorrectly set to adler instead of sequence. @Zbizu tested on Windows and it still sends 5.
I can not test or confirm that it changed for other systems