Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monsters and bosses from 12.60 and 12.20.9066 update #4126

Closed
wants to merge 22 commits into from
Closed

Add monsters and bosses from 12.60 and 12.20.9066 update #4126

wants to merge 22 commits into from

Conversation

omarcopires
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • All monsters from the update have been added.
  • All monster looktypes were taken from staticdata.
  • Bosses may have slightly different looktype colors.

Issues addressed:
#4107

@omarcopires omarcopires changed the title Add monsters and bosses from 12.60 update Add monsters and bosses from 12.60 and 12.20.9066 update May 11, 2022
EPuncker
EPuncker reviewed May 12, 2022
View reviewed changes
data/monster/monsters.xml Outdated Show resolved Hide resolved
data/monster/monsters.xml Outdated Show resolved Hide resolved
data/monster/monsters/angry_elemental.xml Outdated Show resolved Hide resolved
data/monster/monsters/angry_elemental.xml Outdated Show resolved Hide resolved
data/monster/monsters/angry_elemental.xml Outdated Show resolved Hide resolved
data/monster/monsters/quara_saboteur.xml Outdated Show resolved Hide resolved
data/monster/monsters/ratmiral_blackwhiskers.xml Outdated Show resolved Hide resolved
data/monster/monsters/roast_pork.xml Outdated Show resolved Hide resolved
data/monster/monsters/slowing_slime.xml Outdated Show resolved Hide resolved
data/monster/monsters/spy_rat.xml Outdated Show resolved Hide resolved
@soul4soul
Copy link
Contributor

soul4soul commented May 14, 2022 •
edited
Loading

I don't see a plain Spyrat monster but there should be the 4 look directions. I believe the look type for the 4 direction spyrats each look like a different item id, right now they are all set to no looktype.

Search for all monsters that have looktype <look type="0" head="0" body="0" legs="0" feet="0" addons="0" mount="0" corpse="0" /> those are all probably wrong and many of them appear to be items ids not looktypes.

@omarcopires
Copy link
Contributor Author

I don't see a plain monster but there should be the 4 look directions. I believe the look type for the 4 direction spyrats each look like a different item id, right now they are all set to no looktype.Spyrat

Search for all monsters that have looktype those are all probably wrong and many of them appear to be items ids not looktypes.<look type="0" head="0" body="0" legs="0" feet="0" addons="0" mount="0" corpse="0" />

This is just a sketch, I'll still add all the looktypes and after that the attacks. Don't worry about it now!

EPuncker
EPuncker reviewed May 20, 2022
View reviewed changes
data/monster/monsters.xml Outdated Show resolved Hide resolved
EPuncker
EPuncker reviewed May 20, 2022
View reviewed changes
data/monster/monsters/exotic_bat.xml
<flag canwalkonfire="0" />
<flag canwalkonpoison="1" />
</flags>
<defenses armor="40" defense="40" />
Copy link
Contributor

@EPuncker EPuncker May 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing attacks

EPuncker
EPuncker reviewed May 20, 2022
View reviewed changes
data/monster/monsters/exotic_cave_spider.xml
<flag canwalkonenergy="1" />
<flag canwalkonfire="0" />
<flag canwalkonpoison="1" />
</flags>
Copy link
Contributor

@EPuncker EPuncker May 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing attacks

EPuncker
EPuncker reviewed May 20, 2022
View reviewed changes
data/monster/monsters/fat_porker.xml Outdated
<?xml version="1.0" encoding="utf-8"?>
<monster name="Fat Porker" nameDescription="a fat porker" race="blood" experience="0" speed="0">
<health now="20000" max="20000" />
<look type="0" head="0" body="0" legs="0" feet="0" addons="0" mount="0" corpse="0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing looktype and corpse

@omarcopires omarcopires deleted the 1260-monsters branch June 10, 2022 19:10
@omarcopires omarcopires restored the 1260-monsters branch June 10, 2022 19:10
@omarcopires omarcopires reopened this Jun 10, 2022
@omarcopires omarcopires mentioned this pull request Jun 10, 2022
Closed
58 tasks
EPuncker
EPuncker reviewed Jun 11, 2022
View reviewed changes
data/monster/monsters.xml Outdated Show resolved Hide resolved
EPuncker
EPuncker reviewed Jun 11, 2022
View reviewed changes
data/monster/monsters.xml Outdated Show resolved Hide resolved
EPuncker
EPuncker reviewed Jun 11, 2022
View reviewed changes
data/monster/monsters.xml Outdated Show resolved Hide resolved
EPuncker
EPuncker reviewed Jun 11, 2022
View reviewed changes
data/monster/monsters.xml Outdated Show resolved Hide resolved
EPuncker
EPuncker reviewed Jun 11, 2022
View reviewed changes
data/monster/monsters.xml Outdated Show resolved Hide resolved
EPuncker
EPuncker reviewed Jun 19, 2022
View reviewed changes
data/monster/monsters.xml Outdated Show resolved Hide resolved
data/monster/monsters/celebrating_orger.xml
<flag canwalkonfire="1" />
<flag canwalkonpoison="1" />
</flags>
<defenses armor="10" defense="5" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add meele attack 0-1 damage

data/monster/monsters/celebrating_orger.xml Outdated Show resolved Hide resolved
data/monster/monsters/cheese_thief.xml
<flag canwalkonfire="0" />
<flag canwalkonpoison="0" />
</flags>
<defenses armor="10" defense="5" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing attacks

data/monster/monsters/cow.xml
<flag canwalkonenergy="1" />
<flag canwalkonfire="1" />
<flag canwalkonpoison="1" />
</flags>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing attacks

data/monster/monsters/fat_porker.xml
<immunity drunk="1" />
</immunities>
<loot>
<item id="2671" name="ham" chance="100000" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing count for ham and meat

data/monster/monsters/quara_saboteur.xml
<flag canwalkonfire="1" />
<flag canwalkonpoison="1" />
</flags>
<defenses armor="10" defense="5" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing attacks

@omarcopires omarcopires deleted the 1260-monsters branch July 14, 2022 22:29
@omarcopires omarcopires restored the 1260-monsters branch January 9, 2023 01:47
@omarcopires omarcopires reopened this Jan 9, 2023
This was referenced Jan 9, 2023
Open
Closed
@omarcopires omarcopires marked this pull request as ready for review January 10, 2023 22:39
omarcopires and others added 2 commits January 11, 2023 17:18
@omarcopires @EPuncker
Update data/monster/monsters.xml
009a188 
Co-authored-by: Evil Puncker <EPuncker@users.noreply.github.com>
@omarcopires @EPuncker
Update data/monster/monsters/celebrating_orger.xml
21588d4 
Co-authored-by: Evil Puncker <EPuncker@users.noreply.github.com>
@omarcopires omarcopires deleted the 1260-monsters branch January 27, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EPuncker EPuncker EPuncker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omarcopires @soul4soul @EPuncker @torresmon