Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix variable scope in npc.lua #4187

Merged
merged 4 commits into from
Aug 10, 2022
Merged

fix variable scope in npc.lua #4187

merged 4 commits into from
Aug 10, 2022

Conversation

Zbizu
Copy link
Contributor

@Zbizu Zbizu commented Jul 20, 2022

Steps to reproduce

execute print(stuff) out of context (eg with talkaction) after trading with npc

Expected

nil

Observed

userdata

@EPuncker EPuncker merged commit 5a939c4 into otland:master Aug 10, 2022
EPuncker pushed a commit to EPuncker/forgottenserver that referenced this pull request May 23, 2023
@Zbizu @EPuncker
fix variable scope in npc.lua (otland#4187)
06cd4b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramon-bernardo ramon-bernardo ramon-bernardo approved these changes

@EPuncker EPuncker EPuncker approved these changes

@DSpeichert DSpeichert Awaiting requested review from DSpeichert

@nekiro nekiro Awaiting requested review from nekiro

@ranisalt ranisalt Awaiting requested review from ranisalt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zbizu @EPuncker @ramon-bernardo