Fix string view in game world auth

src/iologindata.cpp

@@ -92,7 +92,7 @@ bool IOLoginData::loginserverAuthentication(const std::string& name, const std::
 	return true;
 }
 
-std::pair<uint32_t, std::string_view> IOLoginData::gameworldAuthentication(std::string_view accountName,
+std::pair<uint32_t, std::string> IOLoginData::gameworldAuthentication(std::string_view accountName,
                                                                            std::string_view password,
                                                                            std::string_view characterName,
                                                                            std::string_view token, uint32_t tokenTime)
@@ -102,28 +102,28 @@ std::pair<uint32_t, std::string_view> IOLoginData::gameworldAuthentication(std::
 	    fmt::format("SELECT `id`, `password`, `secret` FROM `accounts` WHERE `name` = {:s} OR `email` = {:s}",
 	                db.escapeString(accountName), db.escapeString(accountName)));
 	if (!result) {
-		return std::make_pair(0, characterName);
+		return std::make_pair(0, "");
 	}
 
 	// two-factor auth
 	if (g_config.getBoolean(ConfigManager::TWO_FACTOR_AUTH)) {
 		std::string secret = decodeSecret(result->getString("secret"));
 		if (!secret.empty()) {
 			if (token.empty()) {
-				return std::make_pair(0, characterName);
+				return std::make_pair(0, "");
 			}
 
 			bool tokenValid = token == generateToken(secret, tokenTime) ||
 			                  token == generateToken(secret, tokenTime - 1) ||
 			                  token == generateToken(secret, tokenTime + 1);
 			if (!tokenValid) {
-				return std::make_pair(0, characterName);
+				return std::make_pair(0, "");
 			}
 		}
 	}
 
 	if (transformToSHA1(password) != result->getString("password")) {
-		return std::make_pair(0, characterName);
+		return std::make_pair(0, "");
 	}
 
 	uint32_t accountId = result->getNumber<uint32_t>("id");
@@ -132,10 +132,9 @@ std::pair<uint32_t, std::string_view> IOLoginData::gameworldAuthentication(std::
 	    fmt::format("SELECT `name` FROM `players` WHERE `name` = {:s} AND `account_id` = {:d} AND `deletion` = 0",
 	                db.escapeString(characterName), accountId));
 	if (!result) {
-		return std::make_pair(0, characterName);
+		return std::make_pair(0, "");
 	}
-
-	return std::make_pair(accountId, result->getString("name"));
+	return std::make_pair(accountId, std::string{result->getString("name")});
 }
 
 uint32_t IOLoginData::getAccountIdByPlayerName(const std::string& playerName)

src/iologindata.h

@@ -20,7 +20,7 @@ class IOLoginData
 	static Account loadAccount(uint32_t accno);
 
 	static bool loginserverAuthentication(const std::string& name, const std::string& password, Account& account);
-	static std::pair<uint32_t, std::string_view> gameworldAuthentication(std::string_view accountName,
+	static std::pair<uint32_t, std::string> gameworldAuthentication(std::string_view accountName,
 	                                                                     std::string_view password,
 	                                                                     std::string_view characterName,
 	                                                                     std::string_view token, uint32_t tokenTime);

src/protocolgame.cpp

@@ -469,14 +469,15 @@ void ProtocolGame::onRecvFirstMessage(NetworkMessage& msg)
 	}
 
 	uint32_t accountId;
-	std::tie(accountId, characterName) =
+	std::string characterNameStr;
+	std::tie(accountId, characterNameStr) =
 	    IOLoginData::gameworldAuthentication(accountName, password, characterName, token, tokenTime);
 	if (accountId == 0) {
 		disconnectClient("Account name or password is not correct.");
 		return;
 	}
 
-	g_dispatcher.addTask([=, thisPtr = getThis(), characterName = std::string{characterName}]() {
+	g_dispatcher.addTask([=, thisPtr = getThis(), characterName = characterNameStr]() {
 		thisPtr->login(characterName, accountId, operatingSystem);
 	});
 }