Perform gameworld authentication using character ID

[ranisalt]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Instead of performing gameworld authentication and login using the character name, instead read the character ID as early as possible and use that instead. This reduces the need to pass strings around.

Issues addressed:
Fixes #4359
Closes #4360

[conde2]

I think this need to be more benchmarked, because having to perform a JOIN is probably worse then passing some strings around.

DBResult_ptr result = db.storeQuery(fmt::format(
	    "SELECT `a`.`id` AS `account_id`, `a`.`password`, `a`.`secret`, `p`.`id` AS `character_id` FROM `accounts` `a` JOIN `players` `p` ON `a`.`id` = `p`.`account_id` WHERE (`a`.`name` = {:s} OR `a`.`email` = {:s}) AND `p`.`name` = {:s} AND `p`.`deletion` = 0",
	    db.escapeString(accountName), db.escapeString(accountName), db.escapeString(characterName)));

[ranisalt]

I think this need to be more benchmarked, because having to perform a JOIN is probably worse then passing some strings around.

This is doing a join on indexed columns. It will be equal or faster than running two separate queries.

I did the test anyway, and on my machine the join takes as much time (0.012s) as each of the separate queries (~0.011s each); therefore it halves the running time.

[ranisalt]

@ArturKnopik could you check if this also fixes #4359 for you or if #4360 is still required? Working fine but I use Linux

[krecikondexin]

@ranisalt i will check it today

[ArturKnopik]

Debug build on windows works without issue, i can login to the game server without any problem

[ranisalt]

Thanks for the review!