Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to game protocol 12.91 #4568

Merged
merged 8 commits into from
Dec 11, 2023
Merged

Update to game protocol 12.91 #4568

merged 8 commits into from
Dec 11, 2023

Conversation

omarcopires
Copy link
Contributor

Pull Request Prelude

Changes Proposed

  • Update protocol for login in version 12.91.
  • Although the code has been updated to uint16_t , purchases are still limited to 100 items. The change was necessary in this pull request to fix crash when opening the NPC window.
  • I will not make/bring the code that brings this increase in quantity, as it is complex and a little big, I will focus only on the protocol part.

@luanluciano93
Copy link
Contributor

for what? If 10.98 doesn't even have the features yet... what's the advantage of advancing a protocol without features?

Copy link
Contributor

@Zbizu Zbizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial tests for protocol and otb integrity seem to be fine

EPuncker
EPuncker previously approved these changes Dec 11, 2023
@omarcopires
Copy link
Contributor Author

omarcopires commented Dec 11, 2023

  • Everything works as it should, except that it is still not possible to acquire more than 100 NPC items.
  • New effects, outfits, depots and mount items have been added.
  • New items can be added later.

As soon as this pull is added I will send a new one with the 13x protocol and the basic sound system.

@EPuncker EPuncker merged commit 12624c4 into otland:master Dec 11, 2023
22 checks passed
@omarcopires omarcopires deleted the protocol-update branch December 12, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants