Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isochrone parallel tests #396

Merged
merged 5 commits into from
Feb 28, 2024
Merged

isochrone parallel tests #396

merged 5 commits into from
Feb 28, 2024

Conversation

knaaptime
Copy link
Member

@knaaptime knaaptime commented Feb 28, 2024

current tests for isochrones fail because multiple processes try to open the h5 file in write mode. Trying to run those tests in sequence (via the same worker?) using a pytest-xdist mark

@knaaptime knaaptime changed the title skplt isochrone parallel tests Feb 28, 2024
@knaaptime
Copy link
Member Author

the remaining failure is windows-only and is some typing error coming from an underying C library somewhere (maybe this)? i dunno

FAILED geosnap/tests/test_isochrones.py::test_isos_from_ids - ValueError: Buffer dtype mismatch, expected 'long' but got 'long long'
FAILED geosnap/tests/test_isochrones.py::test_isos_from_gdf - ValueError: Buffer dtype mismatch, expected 'long' but got 'long long'

long type instead of long long?. That is out of scope here, so i'm going to skip the test on windows unless somebody with a windows box wants to look into it more

@knaaptime knaaptime merged commit 91eebfd into oturns:main Feb 28, 2024
5 checks passed
@knaaptime knaaptime deleted the skplt branch February 28, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant