Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AO3-6211 Exclude tags without posted works from unwrangled bins #4940

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Bilka2
Copy link
Contributor

@Bilka2 Bilka2 commented Oct 12, 2024

Issue

https://otwarchive.atlassian.net/browse/AO3-6211

Purpose

Exclude tags that are only used on draft works from the tag wrangling bins for unwrangled tags.

Testing Instructions

See Jira.

Credit

Bilka (he/him)

@Bilka2
Copy link
Contributor Author

Bilka2 commented Oct 13, 2024

The test failure is in "Fandoms used only on external works should be visible to wranglers." because the external work is not considered a work for has_posted_works. The test was added in AO3-4963.

To me this looks like an acceptable behaviour change, based on informal talk with wranglers it sounds like they don't actively wrangle tags that are only used on external works. So I would propose to remove/adjust this test to expect that fandom tags used only on external works are not visible in the fandom mass bin.

@sarken
Copy link
Collaborator

sarken commented Oct 15, 2024

I'll talk to the wrangling chairs who might want to consult with their team!

@sarken
Copy link
Collaborator

sarken commented Oct 15, 2024

TW chairs have confirmed not showing external work fandoms would be great, thanks! Do you happen to know if there is also a test that shows bookmark-only tags don't show up in bins even after being sorted (i.e., marked a Relationship tag from the Unsorted bin) and assigned to a fandom? If not, it might be good to add a test for that as well.

Copy link
Collaborator

@sarken sarken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as-is, just two little test-related suggestions since it'll be a while before we can get this merged. (Tag Wrangling is going to be so happy when we do!)

features/step_definitions/tag_steps.rb Outdated Show resolved Hide resolved
features/step_definitions/tag_steps.rb Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants