Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen image viewer #229

Merged
merged 3 commits into from
Oct 30, 2022
Merged

Fullscreen image viewer #229

merged 3 commits into from
Oct 30, 2022

Conversation

ouchadam
Copy link
Owner

Adds a fullscreen image viewer, supporting zoom and pan

  • Also fixes a bug where the system bitmap reading can provide inverted width/height values which requires reading the image exif information

@github-actions
Copy link
Contributor

APK Size: 1.99 MB

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #229 (2e2e4af) into main (3df8c0b) will decrease coverage by 0.11%.
The diff coverage is 12.50%.

@@             Coverage Diff              @@
##               main     #229      +/-   ##
============================================
- Coverage     58.74%   58.63%   -0.12%     
+ Complexity      588      587       -1     
============================================
  Files           231      231              
  Lines          5893     5906      +13     
  Branches        697      701       +4     
============================================
+ Hits           3462     3463       +1     
- Misses         2124     2135      +11     
- Partials        307      308       +1     
Impacted Files Coverage Δ
app/src/main/kotlin/app/dapk/st/graph/AppModule.kt 0.00% <0.00%> (ø)
...in/kotlin/app/dapk/st/messenger/MessengerScreen.kt 0.00% <0.00%> (ø)
...ain/kotlin/app/dapk/st/messenger/MessengerState.kt 0.00% <0.00%> (ø)
...k/st/matrix/message/internal/SendMessageUseCase.kt 96.90% <ø> (ø)
...kotlin/app/dapk/st/messenger/MessengerViewModel.kt 31.73% <25.00%> (-1.26%) ⬇️
...p/dapk/st/matrix/sync/internal/sync/SyncUseCase.kt 69.23% <0.00%> (-1.93%) ⬇️
.../st/matrix/crypto/internal/DefaultCryptoService.kt 92.85% <0.00%> (+3.57%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ouchadam ouchadam merged commit 223b5d2 into main Oct 30, 2022
@ouchadam ouchadam deleted the feature/fullscreen-images branch October 30, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant