Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech/redux pattern #234

Merged
merged 9 commits into from
Nov 3, 2022
Merged

tech/redux pattern #234

merged 9 commits into from
Nov 3, 2022

Conversation

ouchadam
Copy link
Owner

@ouchadam ouchadam commented Nov 1, 2022

Introduces a PageReducer and converts the ImageGallery and Settings pages to the pattern

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

APK Size: 2.01 MB

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #234 (533122f) into main (87083b0) will increase coverage by 0.41%.
The diff coverage is 64.58%.

@@             Coverage Diff              @@
##               main     #234      +/-   ##
============================================
+ Coverage     59.16%   59.58%   +0.41%     
+ Complexity      584      568      -16     
============================================
  Files           239      243       +4     
  Lines          6076     6126      +50     
  Branches        717      736      +19     
============================================
+ Hits           3595     3650      +55     
+ Misses         2162     2143      -19     
- Partials        319      333      +14     
Impacted Files Coverage Δ
core/src/main/kotlin/app/dapk/st/core/JobBag.kt 0.00% <0.00%> (ø)
...in/app/dapk/st/directory/state/DirectoryReducer.kt 80.00% <0.00%> (-10.00%) ⬇️
.../dapk/st/messenger/gallery/ImageGalleryActivity.kt 0.00% <ø> (ø)
.../st/messenger/gallery/state/ImageGalleryActions.kt 0.00% <0.00%> (ø)
.../st/messenger/gallery/state/ImageGalleryReducer.kt 30.00% <30.00%> (ø)
...c/main/kotlin/app/dapk/st/core/page/PageReducer.kt 55.26% <55.26%> (ø)
...pk/st/messenger/gallery/state/ImageGalleryState.kt 75.00% <75.00%> (ø)
...tlin/app/dapk/st/settings/state/SettingsReducer.kt 77.01% <77.01%> (ø)
...ains/state/src/main/kotlin/app/dapk/state/State.kt 70.23% <91.30%> (+8.33%) ⬆️
...otlin/app/dapk/st/settings/state/SettingsAction.kt 100.00% <100.00%> (ø)
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ouchadam ouchadam merged commit 40534bc into main Nov 3, 2022
@ouchadam ouchadam deleted the tech/redux-pages branch November 3, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant