Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech/engine tests #250

Merged
merged 6 commits into from
Nov 6, 2022
Merged

Tech/engine tests #250

merged 6 commits into from
Nov 6, 2022

Conversation

ouchadam
Copy link
Owner

@ouchadam ouchadam commented Nov 5, 2022

Improving engine test coverage

  • Fixes automatic marking of rooms as read on new messages

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

APK Size: 2.01 MB

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #250 (6dc98ef) into main (0d0c3d5) will increase coverage by 67.11%.
The diff coverage is 25.58%.

@@             Coverage Diff             @@
##             main     #250       +/-   ##
===========================================
+ Coverage        0   67.11%   +67.11%     
- Complexity      0      634      +634     
===========================================
  Files           0      248      +248     
  Lines           0     5900     +5900     
  Branches        0      737      +737     
===========================================
+ Hits            0     3960     +3960     
- Misses          0     1579     +1579     
- Partials        0      361      +361     
Impacted Files Coverage Δ
...tlin/app/dapk/st/core/extensions/FlowExtensions.kt 0.00% <0.00%> (ø)
...k/st/engine/DirectoryMergeWithLocalEchosUseCase.kt 0.00% <0.00%> (ø)
...rc/main/kotlin/app/dapk/st/engine/InviteUseCase.kt 85.71% <0.00%> (ø)
...ain/kotlin/app/dapk/st/engine/MatrixPushHandler.kt 0.00% <0.00%> (ø)
...n/kotlin/app/dapk/st/engine/ReadMarkingTimeline.kt 80.00% <71.42%> (ø)
...main/kotlin/app/dapk/st/engine/DirectoryUseCase.kt 92.85% <75.00%> (ø)
...n/app/dapk/st/engine/MergeWithLocalEchosUseCase.kt 78.94% <100.00%> (ø)
.../main/kotlin/app/dapk/st/engine/TimelineUseCase.kt 84.61% <100.00%> (ø)
...ain/kotlin/app/dapk/st/matrix/common/CipherText.kt 50.00% <0.00%> (ø)
...in/app/dapk/st/matrix/room/internal/RoomMembers.kt 80.00% <0.00%> (ø)
... and 245 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

- fixes wrong message instance being used for filtering
@ouchadam ouchadam merged commit c848bea into main Nov 6, 2022
@ouchadam ouchadam deleted the tech/engine-tests branch November 6, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant