Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Leave room #302

Merged
merged 2 commits into from
Jan 7, 2023
Merged

[Feature] Leave room #302

merged 2 commits into from
Jan 7, 2023

Conversation

ouchadam
Copy link
Owner

@ouchadam ouchadam commented Jan 7, 2023

  • Adds the ability to leave a room from the room's overflow menu

Fixes #300

DIALOG
Screenshot_20230107_142729

@ouchadam ouchadam changed the title Feature - Leave room [Feature] Leave room Jan 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2023

APK Size: 2.01 MB

@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #302 (e990227) into main (3837dd2) will increase coverage by 0.54%.
The diff coverage is 92.00%.

@@             Coverage Diff              @@
##               main     #302      +/-   ##
============================================
+ Coverage     54.66%   55.21%   +0.54%     
  Complexity      117      117              
============================================
  Files           103      103              
  Lines          1683     1708      +25     
  Branches        232      236       +4     
============================================
+ Hits            920      943      +23     
  Misses          656      656              
- Partials        107      109       +2     
Impacted Files Coverage Δ
...in/kotlin/app/dapk/st/messenger/MessengerScreen.kt 0.00% <ø> (ø)
...lin/app/dapk/st/messenger/state/MessengerAction.kt 50.00% <ø> (ø)
...in/app/dapk/st/messenger/state/MessengerReducer.kt 77.86% <90.00%> (+2.18%) ⬆️
...tlin/app/dapk/st/messenger/state/MessengerState.kt 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ouchadam ouchadam merged commit 449f1bf into main Jan 7, 2023
@ouchadam ouchadam deleted the feature-leave-room branch January 7, 2023 15:04
@notramo
Copy link

notramo commented Jan 7, 2023

@ouchadam When do you plan to release this on Google Play?

@ouchadam
Copy link
Owner Author

ouchadam commented Jan 8, 2023

23/01/01.1 the release is currently rolling out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leave room
2 participants