feat: add audit trailing to facility service actions create, update and delete #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anissa3005
changed the title
ermish
reviewed
Jan 1, 2025
utils/databaseSeedTool.ts
Outdated
| @@ -19,7 +19,7 @@ export const seedDatabase = async () => { | |||
| const facilityIds: string[] = [] | |||
|
|
|||
| for await (const facility of facilities) { | |||
| const createdFacilityResult = await createFacility(facility) | |||
| const createdFacilityResult = await createFacility(facility, 'userId') | |||
There was a problem hiding this comment.
let's pass in something like db Seed tool so we know where it was created
ermish
approved these changes
Jan 1, 2025
There was a problem hiding this comment.
awesome! looks good @Anissa3005 ! There's one comment to check first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ##274
Description
This PR adds audit trailing to the facility service actions: create, update, and delete. It also includes some refactoring to improve functionality and address related issues, such as converting batch writes to transactions.
What changed
createFacilityupdateFacilitydeleteFacility