Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update selective forecasting tests #1312

Merged
merged 2 commits into from
May 12, 2023
Merged

Conversation

ourownstory
Copy link
Owner

adds more diversity to tests

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2023

Codecov Report

Merging #1312 (e756184) into main (209129e) will increase coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1312      +/-   ##
==========================================
+ Coverage   89.84%   89.86%   +0.01%     
==========================================
  Files          38       38              
  Lines        5149     5149              
==========================================
+ Hits         4626     4627       +1     
+ Misses        523      522       -1     

see 1 file with indirect coverage changes

Copy link
Collaborator

@LeonieFreisinger LeonieFreisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@github-actions
Copy link

github-actions bot commented May 2, 2023

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 13.0626 13.0626 0.0%
AirPassengers RMSE_val 15.9452 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88156 9.88156 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 6.7934 5.33 -21.54% 🎉
PeytonManning MAE_val 0.58159 0.58159 -0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 -0.0%
PeytonManning MAE 0.41671 0.41671 -0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 16.2304 12.95 -20.21% 🎉
YosemiteTemps MAE_val 1.3442 1.3442 0.0%
YosemiteTemps RMSE_val 2.00245 2.00245 0.0%
YosemiteTemps Loss_val 0.00077 0.00077 0.0%
YosemiteTemps MAE 1.3192 1.3192 0.0%
YosemiteTemps RMSE 2.13518 2.13518 -0.0%
YosemiteTemps Loss 0.00064 0.00064 0.0%
YosemiteTemps time 75.7593 68.41 -9.7% 🎉
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@ourownstory ourownstory merged commit 214a7ba into main May 12, 2023
@ourownstory ourownstory deleted the tests-selective-forecast branch May 12, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants