-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[major] Upgrade to PyTorch 2 #1404
Conversation
Model Benchmark
|
Codecov Report
@@ Coverage Diff @@
## main #1404 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 38 38
Lines 5068 5068
=======================================
Hits 4554 4554
Misses 514 514
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing, thanks so much Richard!!
@ourownstory what do you think, can we merge that? |
I'll go ahead and merge this now, I think a lot of users are waiting for it. |
2 similar comments
I'll go ahead and merge this now, I think a lot of users are waiting for it. |
I'll go ahead and merge this now, I think a lot of users are waiting for it. |
@noxan this really is amazing, I always had some dependency issues when installing NP with other packages, everything resolved now! |
Also wanted to say thank you to @hxyue1 who contributed to this PR kind of behind the scenes and tried several alternative attempts to make this finally work 🙏 |
Another attempt to upgrade to PyTorch 2.0