Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Accessing None type config_refgressors #1536

Merged
merged 2 commits into from
Feb 19, 2024
Merged

[Fix] Accessing None type config_refgressors #1536

merged 2 commits into from
Feb 19, 2024

Conversation

ourownstory
Copy link
Owner

fixes issue #1535 introduced in #1008

Copy link

github-actions bot commented Feb 19, 2024

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 0.56412 0.56412 0.0%
YosemiteTemps RMSE_val 0.83161 0.83161 0.0%
YosemiteTemps Loss_val 0.0004 0.0004 0.0%
YosemiteTemps MAE 0.98449 0.98449 0.0%
YosemiteTemps RMSE 1.75389 1.75389 0.0%
YosemiteTemps Loss 0.00132 0.00132 0.0%
YosemiteTemps time 37.3835 34.41 -7.95% 🎉
EnergyPriceDaily MAE_val 5.41157 5.41157 0.0%
EnergyPriceDaily RMSE_val 6.71538 6.71538 0.0%
EnergyPriceDaily Loss_val 0.02525 0.02525 0.0%
EnergyPriceDaily MAE 5.94936 5.94936 0.0%
EnergyPriceDaily RMSE 7.9833 7.9833 0.0%
EnergyPriceDaily Loss 0.02579 0.02579 0.0%
EnergyPriceDaily time 16.4742 15.4 -6.52% 🎉
PeytonManning MAE_val 0.34955 0.34955 0.0%
PeytonManning RMSE_val 0.50049 0.50049 0.0%
PeytonManning Loss_val 0.01771 0.01771 0.0%
PeytonManning MAE 0.34653 0.34653 0.0%
PeytonManning RMSE 0.49312 0.49312 0.0%
PeytonManning Loss 0.01464 0.01464 0.0%
PeytonManning time 12.9913 12.24 -5.78% 🎉
AirPassengers MAE_val 30.6285 30.6285 0.0%
AirPassengers RMSE_val 31.5254 31.5254 0.0%
AirPassengers Loss_val 0.01277 0.01277 0.0%
AirPassengers MAE 6.16861 6.16861 0.0%
AirPassengers RMSE 7.85225 7.85225 0.0%
AirPassengers Loss 0.00065 0.00065 0.0%
AirPassengers time 9.15544 8.01 -12.51% 🎉
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

EnergyPriceDaily

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0f034bb) 88.51% compared to head (0f907c6) 88.51%.

Files Patch % Lines
neuralprophet/data/split.py 0.00% 1 Missing ⚠️
neuralprophet/df_utils.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1536   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files          41       41           
  Lines        5329     5330    +1     
=======================================
+ Hits         4717     4718    +1     
  Misses        612      612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ourownstory ourownstory merged commit ce94e56 into main Feb 19, 2024
8 of 12 checks passed
@ourownstory ourownstory deleted the fix-1535 branch February 19, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement in config_regressors Null Check in df_utils.py to Prevent AttributeError
1 participant