Merge pull request #44 from xmusjackson/fix-setexportinfo

Limit substring length in NiHeader::SetExportInfo
ousnius · Aug 4, 2024 · 1124519 · 1124519
2 parents 868b648 + 15099e6
commit 1124519
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/include/BasicTypes.hpp b/include/BasicTypes.hpp
@@ -1012,7 +1012,7 @@ class NiHeader : public NiHeaderBase, public NiCloneable<NiHeader, NiObject> {
 
 	std::string GetExportInfo() const;
 
-	// Sets export info string (automatically split into three members after 256 characters each)
+	// Sets export info string (automatically split into three members after 254 characters each)
 	void SetExportInfo(const std::string& exportInfo);
 
 	// Sets pointer to all blocks in the file

diff --git a/src/BasicTypes.cpp b/src/BasicTypes.cpp
@@ -201,9 +201,9 @@ void NiHeader::SetExportInfo(const std::string& exportInfo) {
 	exportStrings[2] = &exportInfo3;
 
 	auto it = exportStrings.begin();
-	for (size_t i = 0; i < exportInfo.length() && it < exportStrings.end(); i += 256, ++it) {
-		if (i + 256 <= exportInfo.length())
-			(*it)->get() = exportInfo.substr(i, 256);
+	for (size_t i = 0; i < exportInfo.length() && it < exportStrings.end(); i += 254, ++it) {
+		if (i + 254 <= exportInfo.length())
+			(*it)->get() = exportInfo.substr(i, 254);
 		else
 			(*it)->get() = exportInfo.substr(i, exportInfo.length() - i);
 	}