Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS-196: laser scan from ros driver is not properly aligned with point cloud [foxy] #204

Merged
merged 8 commits into from
Nov 29, 2023
Merged

ROS-196: laser scan from ros driver is not properly aligned with point cloud [foxy] #204

merged 8 commits into from
Nov 29, 2023

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Aug 30, 2023 •
edited
Loading

Related Issues & PRs

Summary of Changes

  • Apply destagger to LaserScan message
  • Add LaserScan object to RVIZ
  • Fix an issue where LaserScan does not work properly with using dual mode
  • Address an issue where LaserScan appeared different on FW prior to 2.4

Validation

  • Make sure that the PointCloud and LaserScan fully aligned

@Samahu Samahu added the bug Something isn't working label Aug 30, 2023
@Samahu Samahu self-assigned this Aug 30, 2023
@Samahu Samahu mentioned this pull request Sep 4, 2023
Closed
@Samahu Samahu mentioned this pull request Sep 28, 2023
Open
@Samahu Samahu force-pushed the ROS-196-laser-scan-from-ros-driver-is-not-properly-aligned-with-point-cloud branch from 11908ff to dfa48a4 Compare November 22, 2023 18:11
@Samahu Samahu mentioned this pull request Nov 22, 2023
Merged
@Samahu Samahu changed the title ROS-196: laser scan from ros driver is not properly aligned with point cloud ROS-196: laser scan from ros driver is not properly aligned with point cloud (foxy) Nov 22, 2023
@Samahu Samahu changed the title ROS-196: laser scan from ros driver is not properly aligned with point cloud (foxy) ROS-196: laser scan from ros driver is not properly aligned with point cloud [foxy Nov 22, 2023
@Samahu Samahu changed the title ROS-196: laser scan from ros driver is not properly aligned with point cloud [foxy ROS-196: laser scan from ros driver is not properly aligned with point cloud [foxy] Nov 22, 2023
@Samahu Samahu mentioned this pull request Nov 22, 2023
Merged
@Samahu Samahu requested review from celentes and mtswisher November 23, 2023 02:29
@Samahu Samahu added the enhancement New feature or request label Nov 23, 2023
@Samahu Samahu marked this pull request as ready for review November 23, 2023 20:05
@Samahu Samahu merged commit 874c6bf into ros2-foxy Nov 29, 2023
0 of 2 checks passed
@Samahu Samahu deleted the ROS-196-laser-scan-from-ros-driver-is-not-properly-aligned-with-point-cloud branch November 29, 2023 20:20
@Samahu Samahu mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twslankard twslankard twslankard approved these changes

@celentes celentes Awaiting requested review from celentes

@mtswisher mtswisher Awaiting requested review from mtswisher

@chrisbayruns chrisbayruns Awaiting requested review from chrisbayruns

Assignees

@Samahu Samahu

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Samahu @twslankard