Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update connections to use latest schema models #47

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

Brayden
Copy link
Member

@Brayden Brayden commented Aug 28, 2024

Purpose

This PR is meant to reduce the amount of unused code in the connection and rely more on code that exists already. Also updates how we map database PRAGMA calls to our schema object to make a little more sense. A few other nice to haves outlined below.

Tasks

  • Refactor how the Database and Schema object within it exists, now as a Record<string, Table[]>
  • Refactor the constructor of MotherDuck to be more consistent with our current connections
  • Remove unused properties of MotherDuck such as callback
  • Attempts at simplifying some logic
  • Merge shared schema names into Database object instead of listing out multiple main schemas for example

Verify

Before

After

@Brayden Brayden merged commit 61b4b12 into main Aug 28, 2024
1 check failed
@Brayden Brayden deleted the bwilmoth/schema-refactor branch August 28, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants