Declares indexQuery return type #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laravel Nova has defined a return type for this method and for this, it must also be incorporated into the Trait.
|
I've changed the version of laravel/nova back to 4.24.0 since it has no changes with the latest version. I'll try to search for the change in the laravel/nova package for when the Builder response type was added, but for now this will do. |
|
Thanks a ton @mennotempelaar! :) Your fix is now live in 3.4.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I open Laravel Nova with the implemented package I get the following error: https://flareapp.io/share/q5Yze1Qm. This PR will fix the error.
The Resource class from which the indexQuery method will be overwritten in the HasSortableRows Trait contains the
: Builderresponse type declaration. This PR implements this: Builderresponse type declaration within the HasSortableRows Trait.This fixes the issue.
PS: I've also bumped the laravel/nova version to
^4.27.10.