This repository has been archived by the owner on Apr 20, 2019. It is now read-only.
Bug fix #88 - The function internals.evalResults in lib/batch.js now returns 0 when Hoek.reach evaluates to 0 instead of {}.
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ek.reach evaluated to 0. The issue was fixed. Existing test cases ran perfectly.
adisingh007
changed the title
internals.evalResults in lib/batch.js now returns 0 when Hoek.reach evaluates to 0 instead of {}.
adisingh007
force-pushed
the
bug-fix-bassmaster#88
branch
from
42ecb38
to
2740091
Compare
cadecairos
approved these changes
Sep 4, 2018
There was a problem hiding this comment.
@adisingh007, thank you very much for filing and fixing this issue (and for including tests!) !
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
internals.evalResultsinlib/batch.jsreturned{}even whenevaluated to
0. Since0is afalsyvalue, the line:always evaluated to
{}.This fixes the above mentioned bug number #88 . And also a test case is added to confirm the same.