Skip to content
This repository has been archived by the owner on Apr 20, 2019. It is now read-only.

Fixed Bug where in a pipelined request, if the response of n'th request is needed by any other request where n > 9, i.e. a single digit number, it will work as expected. #98

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

adisingh007
Copy link
Contributor

Closes #97

The problem was in internals.requestRegex.

Where the regex was:

/(?:\/)(?:\$(\d)+\.)?([^\/\$]*)/g  

I changed it to:

/(?:\/)(?:\$(\d+)\.)?([^\/\$]*)/g  

So in the previous buggy regex, \d was in 1 capturing regex group as the + was outside that group.
So I put \d+ in the same capturing group.

I also created a test case for the same. All test cases are working.

…st is needed by any other request where n > 9, i.e. a single digit number, it will work as expected.
Copy link
Contributor

@cadecairos cadecairos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find @adisingh007! Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants