Skip to content
This repository has been archived by the owner on Apr 8, 2019. It is now read-only.

Assignment #1 #36

Closed
wants to merge 4 commits into from
Closed

Assignment #1 #36

wants to merge 4 commits into from

Conversation

MrBri
Copy link

@MrBri MrBri commented Mar 17, 2015

fix #1

Tyler Briles added 4 commits March 15, 2015 23:30
test route
editor settings via editorconfig
watch server file changes via pm2
assert error
update package.json
@@ -0,0 +1 @@
module.exports = require('./lib');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no reason to export here, made the same "mistake" ;)

@AdriVanHoudt
Copy link
Contributor

Tests were not a part of the assignment, great habit though!
Also no need for watch, stop and eslint configs in package.json

handler: function(request, reply) {

return reply({ version: internals.pack.version })
.type('application/json');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to specify type manually. hapi will automatically set it.

@hueniverse hueniverse added this to the 0.0.1 milestone Mar 17, 2015
@hueniverse hueniverse closed this Mar 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a basic HTTP server
3 participants