This repository has been archived by the owner on Apr 8, 2019. It is now read-only.
[Assignment 1] Create a basic HTTP server #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MylesBorins
force-pushed
the
lesson-1
branch
4 times, most recently
from
be2c35d to
45ff9ff
Compare
MylesBorins
changed the title
|
Closes #1 |
| @@ -0,0 +1,26 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
In general, I don't find 'use strict' useful. I don't have an objection to it, but we don't include it in hapi modules.
|
@hueniverse All notes fixed |
| path: '/version', | ||
| handler: function (request, reply) { | ||
|
|
||
| return reply(internals); |
There was a problem hiding this comment.
This is dangerous. internals is expected to grow as the project evolves. By passing it directly here you are basically using a hack. This will cause surprises later when you expose config and other static info that has nothing to do with it.
There was a problem hiding this comment.
updated to response with internals.response. I think this might suffer from a similar problem, as there might be multiple responses. I will be looking through other examples on how to improve this.
This is a first pass at implementing a basic HTTP server that has a single route ```/version``` that returns the version from ```package.json```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass at implementing a basic HTTP server that has a single route
/versionthat returns the version frompackage.jsonThis PR does not include and automated lintint / testing, but it could easily be added.