Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit test code coverage for image, publicip, securitygroup, keypair #163

Merged
1 commit merged into from Oct 31, 2022
Merged

Improve unit test code coverage for image, publicip, securitygroup, keypair #163

1 commit merged into from Oct 31, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 26, 2022

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We have to improve our code coverage for unit test (#151)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #164

Special notes for your reviewer:
It also cover unit test for this PR.
TODOs:

  • squashed commits
  • includes documentation
  • [x ] adds unit tests

@ghost
Copy link
Author

ghost commented Oct 26, 2022

closes #164

@ghost ghost changed the title Improve unit test code coverage Improve unit test code coverage for image, publicip, securitygroup, keypair Oct 26, 2022
@ghost ghost merged commit 2a603cf into outscale:main Oct 31, 2022
@ghost ghost added the kind/cleanup Cleanup label Nov 25, 2022
@ghost ghost added this to the v0.1.2 milestone Nov 25, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Improve code coverage for image, publicip, securitygroup, keypair
2 participants