Multi region #187
Merged
Multi region #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #189 |
|
Closes #181 |
ghost
requested a review
from 
ghost
assigned
Makefile
Outdated
| @@ -25,7 +25,8 @@ OSC_ACCESS_KEY ?= access | |||
| OSC_SECRET_KEY ?= secret | |||
| OSC_CLUSTER ?= cluster-api | |||
| CLUSTER ?= cluster-api | |||
| GH_ORG_NAME ?= outscale-dev | |||
| GH_ORG_NAME ?= outscale-dev | |||
| GH_ORG_USER_NAME ?= outscale-vbr | |||
There was a problem hiding this comment.
I will replace GH_ORG_USER_NAME ?= outscale-vbr
by GH_ORG_USER_NAME ?= outscale-dev
outscale-mdr
requested changes
Dec 2, 2022
Comment on lines
130
to
131
| cloud-provider: external | ||
| provider-id: osc://'{{ ds.meta_data.instance_id }}' | ||
| provider-id: aws:///'{{ ds.meta_data.instance_id }}' |
There was a problem hiding this comment.
this is not for the PR, watchout during the commit !
Makefile
Outdated
| @@ -121,7 +122,7 @@ mock-generate: mockgen ## Generate mock | |||
|
|
|||
| .PHONY: generate-image-docs | |||
| generate-image-docs: | |||
| ./.github/scripts/launch.sh -c ${GIT_BRANCH} -o ${GH_ORG_NAME} -r ${GH_REPO_NAME} -n ${GIT_USERNAME} -e ${GIT_USEREMAIL} | |||
| ./.github/scripts/launch.sh -c "${GIT_BRANCH}" -o "${GH_ORG_NAME}" -r "${GH_REPO_NAME}" -n "${GIT_USERNAME}" -g "${GH_ORG_USER_NAME}" -e "${GIT_USEREMAIL}" | |||
There was a problem hiding this comment.
It is nice to have a new parameter but now we have a lot. Do we really need to introduce a new one ? GH_ORG_USER_NAME has the same value as GH_ORG_NAME. In the future, i don't see why it will be different
There was a problem hiding this comment.
@outscale-mdr Are you ok with the latest version ?
|
@outscale-mdr Are you ok with the latest version ? |
ghost
commented
Dec 12, 2022
.github/scripts/git_command.sh
Outdated
| echo "Set Default Values"; | ||
| GH_ORG_USER_NAME=outscale-vbr | ||
| else | ||
| echo "GH_ORG_USER_NAME is set ti '$GH_ORG_USER_NAME'" |
Makefile
Outdated
| @@ -121,7 +122,7 @@ mock-generate: mockgen ## Generate mock | |||
|
|
|||
| .PHONY: generate-image-docs | |||
| generate-image-docs: | |||
| ./.github/scripts/launch.sh -c ${GIT_BRANCH} -o ${GH_ORG_NAME} -r ${GH_REPO_NAME} -n ${GIT_USERNAME} -e ${GIT_USEREMAIL} | |||
| ./.github/scripts/launch.sh -c "${GIT_BRANCH}" -o "${GH_ORG_NAME}" -r "${GH_REPO_NAME}" -n "${GIT_USERNAME}" -g "${GH_ORG_USER_NAME}" -e "${GIT_USEREMAIL}" | |||
There was a problem hiding this comment.
@outscale-mdr Are you ok with the latest version ?
Comment on lines
130
to
131
| cloud-provider: external | ||
| provider-id: osc://'{{ ds.meta_data.instance_id }}' | ||
| provider-id: aws:///'{{ ds.meta_data.instance_id }}' |
outscale-mdr
approved these changes
Dec 12, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Release image in cloudgouv region
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #189
Fixes #181
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: