Migrate cloudProviderId #197
Conversation
ghost
requested review from
|
@outscale-hmi @outscale-mdr Are you ok with latest changes ? |
| provider-id: aws:///'{{ ds.meta_data.instance_id }}' | ||
| provider-id: aws://eu-west-2a/'{{ ds.meta_data.instance_id }}' |
There was a problem hiding this comment.
"eu-west-2a", it should be retrieve from the metadata.
The following command will give you the subregion:
curl http://169.254.169.254/latest/meta-data/placement/availability-zone
You should test if {{ ds.meta_data.placement.availability_zone }} gives you what you want
| @@ -129,7 +129,7 @@ spec: | |||
| name: "{{ ds.meta_data.local_hostname }}" | |||
| kubeletExtraArgs: | |||
| cloud-provider: external | |||
| provider-id: osc://'{{ ds.meta_data.instance_id }}' | |||
| provider-id: aws://${OSC_SUBREGION_NAME}/'{{ ds.meta_data.instance_id }}' | |||
There was a problem hiding this comment.
Same takes what the metadata server gives you
There was a problem hiding this comment.
@outscale-mdr CI passed and validation on cloudgouv passed
| retryPeriod := 30 * time.Second | ||
| leaseDuration := 80 * time.Second | ||
| renewDeadline := 20 * time.Second | ||
| k8sManager, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{ | ||
| LeaseDuration: &leaseDuration, | ||
| RenewDeadline: &renewDeadline, | ||
| RetryPeriod: &retryPeriod, | ||
| }) |
There was a problem hiding this comment.
@outscale-mdr
To be sure that cluster api be the master controller, not the test.
(Ps Testenv and e2etest has to be slave controller.
It has to be controller to communicate with cluster api object)
There was a problem hiding this comment.
Ok thank you but now are you sure the controller will no be a master ?
There was a problem hiding this comment.
I try several time with my runner and the controller was not the master.
ghost
added
the
What type of PR is this?
/kind bug
What this PR does / why we need it:
Migrate cloudProviderId from osc:// to aws:///
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #196
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: