Add bastion #198
Merged
Add bastion #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
changed the title
outscale-mdr
approved these changes
Jan 23, 2023
Comment on lines
167
to
172
| for _, subnetSpec := range subnetsSpec { | ||
| subnetName := subnetSpec.Name | ||
| ipSubnetRange := subnetSpec.IpSubnetRange | ||
| clusterScope.Info("Get IpSubnetRange", "ipSubnetRange", ipSubnetRange) | ||
| clusterScope.Info("Get subnetName", "subnetName", subnetName) | ||
| } |
There was a problem hiding this comment.
What is the use of this for loop ?
Does it matter if ipSubnetRange is overrided if there are multiple subnets ?
Comment on lines
+186
to
+181
| _, err := infrastructurev1beta1.ValidateIops(rootDiskIops) | ||
| if err != nil { | ||
| return bastionTagName, err | ||
| } |
There was a problem hiding this comment.
I recently discovered that the ratio iops/size should not execeed 300, mayeb check that in the future
There was a problem hiding this comment.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add optional bastion
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #35
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: