Expose Status machine adresss ip #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
ghost
assigned
ghost
marked this pull request as ready for review
|
@outscale-hmi @outscale-mdr are you ok with this pr ? |
outscale-hmi
reviewed
Mar 9, 2023
cloud/tag/tag.go
Outdated
| @@ -28,7 +28,7 @@ import ( | |||
| ) | |||
|
|
|||
| // AddTag add a tag to a resource | |||
| //func AddTag(tagKey string, tagValue string, resourceIds []string, api *osc.APIClient, auth context.Context) (error, *http.Response) { | |||
| // func AddTag(tagKey string, tagValue string, resourceIds []string, api *osc.APIClient, auth context.Context) (error, *http.Response) { | |||
There was a problem hiding this comment.
you should rebase,
this change is in several PR
also AddTag in the comment parameters don't have the same parameters
as AddTag(createTagRequest osc.CreateTagsRequest, resourceIds []string, api *osc.APIClient, auth context.Context) (error, *http.Response)
| @@ -921,8 +925,10 @@ func (network *OscNetwork) SetSecurityGroupDefaultValue() { | |||
| if network.ClusterName != "" { | |||
| securityGroupRuleApiKubeletKwName = strings.Replace(DefaultSecurityGroupRuleApiKubeletKwName, DefaultClusterName, network.ClusterName, -1) | |||
| securityGroupRuleApiKubeletKcpName = strings.Replace(DefaultSecurityGroupRuleApiKubeletKcpName, DefaultClusterName, network.ClusterName, -1) | |||
| securityGroupRuleNodeIpKwName = strings.Replace(DefaultSecurityGroupRuleNodeIpKwName, DefaultClusterName, network.ClusterName, -1) | |||
| securityGroupRuleNodeIpKcpName = strings.Replace(DefaultSecurityGroupRuleNodeIpKcpName, DefaultClusterName, network.ClusterName, -1) | |||
| securityGroupRuleKwNodeIpKwName = strings.Replace(DefaultSecurityGroupRuleKwNodeIpKwName, DefaultClusterName, network.ClusterName, -1) | |||
There was a problem hiding this comment.
Is this change related to expose machine address ip ?
There was a problem hiding this comment.
We need to expose machine address ip but there are also some ports are missing for microk8s.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Expose node ip address for machine in status (which is used by microK8s bootstrapper)
Open missing flux
And add example for microk8s.
Closes #222
Which issue(s) this PR fixes :
Fixes #222
Special notes for your reviewer:
Optional addresses
https://cluster-api.sigs.k8s.io/developer/architecture/controllers/machine.html
TODOs: