Vm controller unit tests #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
* Handle link and unlink volume * Handle add vm as backend * Handle attach eip * Handle add sg with vm sgmember * Update volume unit test * Add vm unit test
| loadBalancerSecurityGroupClusterScopeName := loadBalancerSecurityGroupName + "-" + clusterScope.GetUID() | ||
| associateSecurityGroupId := securityGroupsRef.ResourceMap[loadBalancerSecurityGroupClusterScopeName] | ||
| machineScope.Info("Get sg", "associateSecurityGroupId", associateSecurityGroupId) | ||
| _, err = securityGroupSvc.CreateSecurityGroupRule(associateSecurityGroupId, flow, ipProtocol, "", securityGroupIds[0], fromPortRange, toPortRange) | ||
| _, err = securityGroupSvc.CreateSecurityGroupRule(associateSecurityGroupId, "Outbound", ipProtocol, "", securityGroupIds[0], fromPortRange, toPortRange) |
There was a problem hiding this comment.
In SecurityGroup, there is a default rules to allow all outbound traffic, no ?
There was a problem hiding this comment.
@outscale-mdr
Yes, there is a default rules which allow outbound traffic, but you have to set outbound security group rule (in lbu sg) for each securityGroup (securityGroupMember) associate to your backend instance associate with lbu.
And you have to set inbound security group rule in each sg backend instance associate with lbu securityGroupMember.
(https://docs.outscale.com/fr/userguide/%C3%80-propos-des-security-groups-dans-LBU.html)
There was a problem hiding this comment.
default rules which allow outbound traffic is not enough for lbu.
ghost
mentioned this pull request
outscale-mdr
approved these changes
Aug 11, 2022
|
close #29 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #29
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: