Skip to content

Commit

Permalink
rustc_codegen_ssa: use try_canonicalize in rpath
Browse files Browse the repository at this point in the history
This is simpler and avoids unnecessary calls to `env::current_dir`.
  • Loading branch information
tamird committed Oct 6, 2023
1 parent a081007 commit 5aeb6a3
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions compiler/rustc_codegen_ssa/src/back/rpath.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
use pathdiff::diff_paths;
use rustc_data_structures::fx::FxHashSet;
use std::env;
use rustc_fs_util::try_canonicalize;
use std::ffi::OsString;
use std::fs;
use std::path::{Path, PathBuf};

pub struct RPathConfig<'a> {
Expand Down Expand Up @@ -82,12 +81,11 @@ fn get_rpath_relative_to_output(config: &mut RPathConfig<'_>, lib: &Path) -> OsS
// Mac doesn't appear to support $ORIGIN
let prefix = if config.is_like_osx { "@loader_path" } else { "$ORIGIN" };

let cwd = env::current_dir().unwrap();
let mut lib = fs::canonicalize(&cwd.join(lib)).unwrap_or_else(|_| cwd.join(lib));
lib.pop(); // strip filename
let mut output = cwd.join(&config.out_filename);
output.pop(); // strip filename
let output = fs::canonicalize(&output).unwrap_or(output);
// Strip filenames
let lib = lib.parent().unwrap();
let output = config.out_filename.parent().unwrap();
let lib = try_canonicalize(lib).unwrap();
let output = try_canonicalize(output).unwrap();
let relative = path_relative_from(&lib, &output)
.unwrap_or_else(|| panic!("couldn't create relative path from {output:?} to {lib:?}"));

Expand Down

0 comments on commit 5aeb6a3

Please sign in to comment.