ci: run clang-format on .h files too (#14597)

Co-authored-by: nektro <nektro@users.noreply.github.com>

cmake/analysis/RunClangFormat.cmake

@@ -1,6 +1,11 @@
 # https://clang.llvm.org/docs/ClangFormat.html
 
-set(CLANG_FORMAT_SOURCES ${BUN_C_SOURCES} ${BUN_CXX_SOURCES})
+file(GLOB BUN_H_SOURCES LIST_DIRECTORIES false ${CONFIGURE_DEPENDS}
+  ${CWD}/src/bun.js/bindings/*.h
+  ${CWD}/src/bun.js/modules/*.h
+)
+
+set(CLANG_FORMAT_SOURCES ${BUN_C_SOURCES} ${BUN_CXX_SOURCES} ${BUN_H_SOURCES})
 
 register_command(
   TARGET

src/bun.js/bindings/BufferEncodingType.h

@@ -17,4 +17,4 @@ enum class BufferEncodingType {
 
 };
 
-}
+}

src/bun.js/bindings/BunClientData.h

@@ -199,4 +199,4 @@ namespace WebCore {
 using JSVMClientData = WebCore::JSVMClientData;
 using JSHeapData = WebCore::JSHeapData;
 
-}
+}

src/bun.js/bindings/BunInjectedScriptHost.h

@@ -12,4 +12,4 @@ class BunInjectedScriptHost final : public Inspector::InjectedScriptHost {
     bool isHTMLAllCollection(JSC::VM&, JSC::JSValue) override { return false; }
 };
 
-}
+}

src/bun.js/bindings/BunPlugin.h

@@ -106,4 +106,4 @@ class GlobalObject;
 namespace Bun {
 JSC::JSValue runVirtualModule(Zig::GlobalObject*, BunString* specifier, bool& wasModuleMock);
 JSC::Structure* createModuleMockStructure(JSC::VM& vm, JSC::JSGlobalObject* globalObject, JSC::JSValue prototype);
-}
+}

src/bun.js/bindings/BunWorkerGlobalScope.h

@@ -53,4 +53,4 @@ class WorkerGlobalScope : public RefCounted<WorkerGlobalScope>, public EventTarg
 private:
     MessagePortChannelProviderImpl* m_messagePortChannelProvider;
 };
-}
+}

src/bun.js/bindings/CachedScript.h

@@ -6,4 +6,4 @@ namespace WebCore {
 
 class CachedScript {
 };
-}
+}

src/bun.js/bindings/CallSitePrototype.h

@@ -44,4 +44,4 @@ class CallSitePrototype final : public JSC::JSNonFinalObject {
     void finishCreation(JSC::VM& vm, JSC::JSGlobalObject* globalObject);
 };
 
-}
+}

src/bun.js/bindings/DeleteCallbackDataTask.h

@@ -13,4 +13,4 @@ class DeleteCallbackDataTask : public EventLoopTask {
     }
 };
 
-}
+}

src/bun.js/bindings/EventLoopTask.h

@@ -41,4 +41,4 @@ class EventLoopTask {
     bool m_isCleanupTask;
 };
 
-}
+}

src/bun.js/bindings/GCDefferalContext.h

@@ -18,4 +18,4 @@ ALWAYS_INLINE GCDeferralContext::~GCDeferralContext()
         m_vm.heap.collectIfNecessaryOrDefer();
 }
 
-} // namespace JSC
+} // namespace JSC

src/bun.js/bindings/IDLTypes.h

@@ -414,4 +414,4 @@ template<typename T>
 struct IsIDLArrayBufferViewAllowShared : public std::integral_constant<bool, std::is_base_of<IDLAllowSharedAdaptor<IDLArrayBufferView>, T>::value> {
 };
 
-} // namespace WebCore
+} // namespace WebCore

src/bun.js/bindings/JS2Native.h

@@ -10,4 +10,4 @@ JSC_DECLARE_HOST_FUNCTION(jsDollarCpp);
 JSC_DECLARE_HOST_FUNCTION(jsDollarZig);
 
 } // namespace JS2Native
-} // namespace Bun
+} // namespace Bun

src/bun.js/bindings/JSBundlerPlugin.h

@@ -69,4 +69,4 @@ class BundlerPlugin final {
     bool tombstoned { false };
 };
 
-} // namespace Zig
+} // namespace Zig

src/bun.js/bindings/JSCTaskScheduler.h

@@ -26,4 +26,4 @@ class JSCTaskScheduler {
     HashSet<Ref<JSC::DeferredWorkTimer::TicketData>> m_pendingTicketsOther;
 };
 
-}
+}

src/bun.js/bindings/JSCTestingHelpers.h

@@ -2,4 +2,4 @@ namespace Bun {
 
 JSC::JSValue createJSCTestingHelpers(Zig::GlobalObject* global);
 
-}
+}

src/bun.js/bindings/JSDOMConvertBufferSource+JSBuffer.h

@@ -8,4 +8,4 @@
 
 namespace WebCore {
 
-}
+}

src/bun.js/bindings/JSDOMGlobalObject.h

@@ -35,4 +35,4 @@ JSClass* toJSDOMGlobalObject(JSC::VM& vm, JSC::JSValue value)
     return nullptr;
 }
 
-}
+}

src/bun.js/bindings/JSEnvironmentVariableMap.h

@@ -12,4 +12,4 @@ namespace Bun {
 
 JSC::JSValue createEnvironmentVariablesMap(Zig::GlobalObject* globalObject);
 
-}
+}

src/bun.js/bindings/JSNextTickQueue.h

@@ -37,4 +37,4 @@ class JSNextTickQueue : public JSC::JSInternalFieldObjectImpl<3> {
     bool isEmpty();
     void drain(JSC::VM& vm, JSC::JSGlobalObject* globalObject);
 };
-}
+}

src/bun.js/bindings/JSWrappingFunction.h

@@ -71,4 +71,4 @@ class JSWrappingFunction final : public JSC::JSFunction {
     JSC::WriteBarrier<JSC::JSFunction> m_wrappedFn;
 };
 
-}
+}

src/bun.js/bindings/NodeAsyncHooks.h

@@ -2,7 +2,7 @@
 #include "ZigGlobalObject.h"
 
 namespace Bun {
-  
+
 JSC::JSValue createAsyncHooksBinding(Zig::GlobalObject*);
 
-}
+}

src/bun.js/bindings/NodeFetch.h

@@ -4,4 +4,4 @@ namespace Bun {
 
 JSC::JSValue createNodeFetchInternalBinding(Zig::GlobalObject*);
 
-}
+}

src/bun.js/bindings/NodeHTTP.h

@@ -1,11 +1,11 @@
 #include "config.h"
 
 namespace Bun {
-  
+
 JSC_DECLARE_HOST_FUNCTION(jsHTTPAssignHeaders);
 JSC_DECLARE_HOST_FUNCTION(jsHTTPGetHeader);
 JSC_DECLARE_HOST_FUNCTION(jsHTTPSetHeader);
 
 JSC::JSValue createNodeHTTPInternalBinding(Zig::GlobalObject*);
 
-}
+}

src/bun.js/bindings/NodeTLS.h

@@ -2,7 +2,7 @@
 #include "ZigGlobalObject.h"
 
 namespace Bun {
-  
+
 JSC::JSValue createNodeTLSBinding(Zig::GlobalObject*);
 
-}
+}

src/bun.js/bindings/NodeURL.h

@@ -5,4 +5,4 @@ namespace Bun {
 
 JSC::JSValue createNodeURLBinding(Zig::GlobalObject*);
 
-} // namespace Bun
+} // namespace Bun

src/bun.js/bindings/Path.h

@@ -2,7 +2,7 @@
 #include "ZigGlobalObject.h"
 
 namespace Bun {
-    
+
 JSC::JSValue createNodePathBinding(Zig::GlobalObject* globalObject);
 
 } // namespace Bun

src/bun.js/bindings/ProcessBindingTTYWrap.h

@@ -15,4 +15,4 @@ JSC::JSValue createNodeTTYWrapObject(JSC::JSGlobalObject* globalObject);
 
 JSC_DECLARE_HOST_FUNCTION(Process_functionInternalGetWindowSize);
 
-}
+}

src/bun.js/bindings/ProcessBindingUV.h

@@ -10,4 +10,4 @@ JSC_DECLARE_HOST_FUNCTION(jsGetErrorMap);
 JSC::JSObject* create(JSC::VM& vm, JSC::JSGlobalObject* globalObject);
 
 } // namespace ProcessBindingUV
-} // namespace Bun
+} // namespace Bun

src/bun.js/bindings/ScriptExecutionContext.h

@@ -206,4 +206,4 @@ class ScriptExecutionContext : public CanMakeWeakPtr<ScriptExecutionContext> {
 
 ScriptExecutionContext* executionContext(JSC::JSGlobalObject*);
 
-}
+}

src/bun.js/bindings/Sink.h

@@ -14,4 +14,4 @@ enum SinkID : uint8_t {
 static constexpr unsigned numberOfSinkIDs
     = 7;
 
-}
+}

src/bun.js/bindings/Strong.h

@@ -31,4 +31,4 @@ class StrongRef {
     JSC::Strong<JSC::Unknown> m_cell;
 };
 
-}
+}

src/bun.js/bindings/Undici.h

@@ -3,4 +3,4 @@ namespace Bun {
 
 JSC::JSValue createUndiciInternalBinding(Zig::GlobalObject* globalObject);
 
-}
+}

src/bun.js/bindings/UtilInspect.h

@@ -4,4 +4,4 @@ namespace Bun {
 
 JSC::Structure* createUtilInspectOptionsStructure(JSC::VM& vm, JSC::JSGlobalObject* globalObject);
 
-}
+}

src/bun.js/bindings/debug-helpers.h

@@ -15,4 +15,4 @@ Inspector::InspectorDebuggerAgent* debuggerAgent(JSC::JSGlobalObject* globalObje
 
     return nullptr;
 }
-}
+}

src/bun.js/bindings/isBuiltinModule.h

@@ -1,5 +1,5 @@
 #pragma once
 
 namespace Bun {
-bool isBuiltinModule(const String &namePossiblyWithNodePrefix);
-} // namespace Bun
+bool isBuiltinModule(const String& namePossiblyWithNodePrefix);
+} // namespace Bun

src/bun.js/bindings/napi_external.h

@@ -100,4 +100,4 @@ class NapiExternal : public JSC::JSDestructibleObject {
 #endif
 };
 
-} // namespace Zig
+} // namespace Zig

src/bun.js/bindings/wtf-bindings.h

@@ -12,4 +12,4 @@ class VM;
 namespace Bun {
 String base64URLEncodeToString(Vector<uint8_t> data);
 size_t toISOString(JSC::VM& vm, double date, char buffer[64]);
-}
+}

src/bun.js/modules/AbortControllerModuleModule.h

@@ -9,46 +9,44 @@ using namespace WebCore;
 namespace Zig {
 
 inline void generateNativeModule_AbortControllerModule(
-    JSC::JSGlobalObject *lexicalGlobalObject, JSC::Identifier moduleKey,
-    Vector<JSC::Identifier, 4> &exportNames,
-    JSC::MarkedArgumentBuffer &exportValues) {
+    JSC::JSGlobalObject* lexicalGlobalObject, JSC::Identifier moduleKey,
+    Vector<JSC::Identifier, 4>& exportNames,
+    JSC::MarkedArgumentBuffer& exportValues)
+{
 
-  Zig::GlobalObject *globalObject =
-      reinterpret_cast<Zig::GlobalObject *>(lexicalGlobalObject);
-  JSC::VM &vm = globalObject->vm();
+    Zig::GlobalObject* globalObject = reinterpret_cast<Zig::GlobalObject*>(lexicalGlobalObject);
+    JSC::VM& vm = globalObject->vm();
 
-  auto *abortController =
-      WebCore::JSAbortController::getConstructor(vm, globalObject).getObject();
-  JSValue abortSignal =
-      WebCore::JSAbortSignal::getConstructor(vm, globalObject);
+    auto* abortController = WebCore::JSAbortController::getConstructor(vm, globalObject).getObject();
+    JSValue abortSignal = WebCore::JSAbortSignal::getConstructor(vm, globalObject);
 
-  const auto controllerIdent = Identifier::fromString(vm, "AbortController"_s);
-  const auto signalIdent = Identifier::fromString(vm, "AbortSignal"_s);
-  const Identifier esModuleMarker = builtinNames(vm).__esModulePublicName();
+    const auto controllerIdent = Identifier::fromString(vm, "AbortController"_s);
+    const auto signalIdent = Identifier::fromString(vm, "AbortSignal"_s);
+    const Identifier esModuleMarker = builtinNames(vm).__esModulePublicName();
 
-  exportNames.append(vm.propertyNames->defaultKeyword);
-  exportValues.append(abortController);
+    exportNames.append(vm.propertyNames->defaultKeyword);
+    exportValues.append(abortController);
 
-  exportNames.append(signalIdent);
-  exportValues.append(abortSignal);
+    exportNames.append(signalIdent);
+    exportValues.append(abortSignal);
 
-  exportNames.append(controllerIdent);
-  exportValues.append(abortController);
+    exportNames.append(controllerIdent);
+    exportValues.append(abortController);
 
-  exportNames.append(esModuleMarker);
-  exportValues.append(jsBoolean(true));
+    exportNames.append(esModuleMarker);
+    exportValues.append(jsBoolean(true));
 
-  // https://github.com/mysticatea/abort-controller/blob/a935d38e09eb95d6b633a8c42fcceec9969e7b05/dist/abort-controller.js#L125
-  abortController->putDirect(
-      vm, signalIdent, abortSignal,
-      static_cast<unsigned>(PropertyAttribute::DontDelete));
+    // https://github.com/mysticatea/abort-controller/blob/a935d38e09eb95d6b633a8c42fcceec9969e7b05/dist/abort-controller.js#L125
+    abortController->putDirect(
+        vm, signalIdent, abortSignal,
+        static_cast<unsigned>(PropertyAttribute::DontDelete));
 
-  abortController->putDirect(
-      vm, controllerIdent, abortController,
-      static_cast<unsigned>(PropertyAttribute::DontDelete));
+    abortController->putDirect(
+        vm, controllerIdent, abortController,
+        static_cast<unsigned>(PropertyAttribute::DontDelete));
 
-  abortController->putDirect(
-      vm, vm.propertyNames->defaultKeyword, abortController,
-      static_cast<unsigned>(PropertyAttribute::DontDelete));
+    abortController->putDirect(
+        vm, vm.propertyNames->defaultKeyword, abortController,
+        static_cast<unsigned>(PropertyAttribute::DontDelete));
 }
 } // namespace Zig