Fix URL.canParse.length (#9710)

* Fix URL.canParse.length * Add URL.canParse.length test --------- Co-authored-by: John-David Dalton <john.david.dalton@gmail.com>
oven-sh · Mar 29, 2024 · 9ecb691 · 9ecb691
1 parent fb8a299
commit 9ecb691
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/bun.js/bindings/webcore/JSDOMURL.cpp b/src/bun.js/bindings/webcore/JSDOMURL.cpp
@@ -132,7 +132,7 @@ using JSDOMURLDOMConstructor = JSDOMConstructor<JSDOMURL>;
 static const HashTableValue JSDOMURLConstructorTableValues[] = {
     { "createObjectURL"_s, static_cast<unsigned>(JSC::PropertyAttribute::Function), NoIntrinsic, { HashTableValue::NativeFunctionType, jsDOMURLConstructorFunction_createObjectURL, 1 } },
     { "revokeObjectURL"_s, static_cast<unsigned>(JSC::PropertyAttribute::Function), NoIntrinsic, { HashTableValue::NativeFunctionType, jsDOMURLConstructorFunction_revokeObjectURL, 1 } },
-    { "canParse"_s, static_cast<unsigned>(JSC::PropertyAttribute::Function), NoIntrinsic, { HashTableValue::NativeFunctionType, jsDOMURLConstructorFunction_canParse, 2 } },
+    { "canParse"_s, static_cast<unsigned>(JSC::PropertyAttribute::Function), NoIntrinsic, { HashTableValue::NativeFunctionType, jsDOMURLConstructorFunction_canParse, 1 } },
 };
 
 static inline JSC::EncodedJSValue constructJSDOMURL1(JSGlobalObject* lexicalGlobalObject, CallFrame* callFrame)

diff --git a/test/js/web/url/url.test.ts b/test/js/web/url/url.test.ts
@@ -226,5 +226,9 @@ describe("url", () => {
         expect(URL.canParse(url, base)).toBe(expected);
       });
     });
+
+    it("URL.canParse.length should be 1", () => {
+      expect(URL.canParse.length).toBe(1);
+    });
   });
 });