Speculative fix for alignment crash in directory iterator on Windows

[Jarred-Sumner]

What does this PR do?

We've received about 16 crash reports for an alignment issue in the directory iterator code

So let's loosen the alignment requirements here and see if it goes away

This structure must be aligned on a LONGLONG (8-byte) boundary. If a buffer contains two or more of these structures, the NextEntryOffset value in each entry, except the last, falls on an 8-byte boundary.

See also: ziglang/zig#17958

How did you verify your code works?

[github-actions]

❌ @Jarred-Sumner, your commit has failing tests :(

💪 1 failing tests Darwin AARCH64

• test/js/bun/http/serve.test.ts 1 failing

💻 1 failing tests Darwin x64 baseline

• test/cli/install/registry/bun-install-registry.test.ts 3 failing

💻 1 failing tests Darwin x64

• test/js/node/http2/node-http2.test.js 1 failing

🐧💪 2 failing tests Linux AARCH64

• test/js/node/http2/node-http2.test.js 1 failing
• test/js/node/os/os.test.js 1 failing

🐧🖥 2 failing tests Linux x64 baseline

• test/js/node/child_process/child_process-node.test.js 1 failing
• test/js/node/http2/node-http2.test.js 1 failing

🐧🖥 1 failing tests Linux x64

• test/js/node/http2/node-http2.test.js 1 failing

🪟💻 9 failing tests Windows x64 baseline

• test/cli/install/bunx.test.ts 1 failing
• test/integration/next-pages/test/dev-server-ssr-100.test.ts 1 failing
• test/integration/next-pages/test/dev-server.test.ts 1 failing
• test/integration/next-pages/test/next-build.test.ts 1 failing
• test/js/bun/shell/bunshell.test.ts 2 failing
• test/js/node/dns/node-dns.test.js 3 failing
• test/js/node/watch/fs.watchFile.test.ts 1 failing
• test/js/web/fetch/fetch.tls.test.ts 1 failing
• test/js/web/workers/worker.test.ts SIGTERM

🪟💻 9 failing tests Windows x64

• test/cli/install/bunx.test.ts 1 failing
• test/cli/install/registry/bun-install-registry.test.ts 3 failing
• test/integration/next-pages/test/dev-server-ssr-100.test.ts 1 failing
• test/integration/next-pages/test/dev-server.test.ts 1 failing
• test/integration/next-pages/test/next-build.test.ts 1 failing
• test/js/bun/shell/bunshell.test.ts 2 failing
• test/js/node/dns/node-dns.test.js 2 failing
• test/js/web/fetch/fetch.tls.test.ts 1 failing
• test/js/web/workers/worker.test.ts SIGTERM

View logs

[zackradisic]

this is an insane bug

i left some ocmments

[zackradisic]

If the struct is unaligned, even if we cast alignment, do we have to worry about unaligned reads? Technically that is undefined behavior right?

[Jarred-Sumner]

if the expected alignment is 2 but the alignment we're seeing is 8, then it is also 2 so that should be okay